Refactor Scala version check and add some tests for unsupported Scala versions #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ckipp01 if you have a couple minutes, please check it out |
ckipp01
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
This is all much nicer to work with. I know you have it covered with a bunch of itest, nice job adding those, but I also always find it worth the time to unit test classes like these as you often get way more coverage that way, and it's easy to miss something. But it's not a blocker.
There was a problem hiding this comment.
Thanks for the review!
I was on the fence myself with adding unit tests or not as there were none here , but after your comment I decided that it won't hurt to have those as well :)
…ported Scala versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.