-
Notifications
You must be signed in to change notification settings - Fork 380
STRATCONN-6101/wrong-description #7808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HI @arnav777dev - when I build the site locally it's still broken. ![]() |
Hey @stayseesong, ![]() I’m not too familiar with Liquid quirks here — maybe someone closer to the docs setup might spot what’s going on. |
hi @arnav777dev - I'll take a look and see if I can figure out what's going on. In the meantime: the Slack thread mentioned this might need to be updated to be a required setting. Are you able to do that on your end? |
hi @arnav777dev - see the screenshot below, I think we fixed it! 🥳 ![]() |
@forstisabella hmm am I doing something wrong? When I run it locally, I don't see the fix |
hi @stayseesong you may just need to close and then rebuild the local site, as anything in a folder that begins with a |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
A customer reached out letting us know that the Kinesis Firehose destination is missing a description for the mixed setting. Raised the question in the #questions-destinations Slack channel
Added empty array check to defaultValue condition in destination footer
Merge timing
Closes #5673