Lr functions edits #911
Lr functions edits #911
Conversation
sanscontext
requested review from
benhorowitz,
danielstjules,
francisco,
misteryeo,
n2parko,
notfelineit and
rarchana2001asu
as code owners
|
Let me try something to see if I can get this to hide the merge of master |
|
Heck yes, that worked! |
There was a problem hiding this comment.
Overall, I think the content is great now.
I'm definitely not a fan of breaking out the Functions Environment page but happy to chat more about that.
As for the sub-headings mentioning the type of function every time - that seems extraneous to me if the whole page itself is for that type of function anyway. This I'm not fussed about if we go this way, but just my two cents.
|
Addressing your comment on headings here: We add the extra words because headings are all indexed by our search provider and returned as part of search results, and it's important to differentiate between different versions of the content in the returned results. I realize this isn't great aesthetically, but I'll go for reader experience over design in most cases. I do think we could widen the column for that right TOC bar though, so we can bring that up to Tonik. |
This is a huge restructure, so it's probably worth just checking it out locally and running it :) cc @misteryeo