Skip to content

Fix: override wildcard glob pattern (**) in resolveFilePathsFromPatterns #5825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmuens merged 2 commits into from
Feb 13, 2019
Merged

Fix: override wildcard glob pattern (**) in resolveFilePathsFromPatterns #5825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db47531
Allow override wildcard glob pattern (**) in resolveFilePathsFromPatt…
svlapin Feb 11, 2019
6dfe485
Add clarification comment
pmuens Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/plugins/package/lib/packageService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,10 @@ module.exports = {
params.include.forEach((pattern) => {
patterns.push(pattern);
});
return globby(params.include.concat(['**']), {
// NOTE: please keep this order of concatenating the include params
// rather than doing it the other way round!
// see https://github.com/serverless/serverless/pull/5825 for more information
return globby(['**'].concat(params.include), {
cwd: path.join(this.serverless.config.servicePath, prefix || ''),
dot: true,
silent: true,
Expand Down