Could you add tests for this @mwielgoszewski ?

@sigmavirus24 I'd be happy to, however I'm not sure where the best place to add them is. Some likely candidates are:

• integration/test_orgs.py
• integration/test_orgs_team.py
• unit/test_orgs.py
• unit/test_orgs_team.py

Would the test be best under integration or unit? I would need to mock the server-side reply which returns the users filtered based on their role. Where would that information reside? Another issue I had in my earlier pull request was filtering users with 2fa_disabled. This information was only available to owners, as can be seen in the following request (how would we test that?):

$ curl https://api.github.com/orgs/hapy/members?filter=2fa_disabled
{
  "message": "Only owners can use this filter.",
  "documentation_url": "https://developer.github.com/v3/orgs/members/#audit-two-factor-auth"
}

To test the Accept header, this appears to already be covered in unit/test_structs.py.

Any guidance you can provide would be appreciated.

So if you look at #395 (which I consider to be easily one of the most complete pull requests I've received recently) you'll see that @antoine-g added both an integration test and a unit test.

Since you're adding functionality to both the Team and Organization classes, you'll need to add at least one test to each of those files.

If there are integration tests that require you to be an org owner (and you aren't already one) do something like:

@pytest.mark.xfail(reason="sigmavirus24 needs to actually write a test for this")
def test_can_filter_organization_members_by_role(self):
    """Show that an owner can filter organization members by role."""
    # TODO(sigmavirus24): Write this integration test
    assert False

@sigmavirus24 I've added the necessary unit tests, integration tests, and cassettes in 7d3254b. I think the 2fa_disabled filter could have a second look, as this should only be available to organization owners.

@mwielgoszewski looks great! Could you just add 2 or 3 more unit tests to ensure that passing a bogus role/filter won't be passed through? E.g., tests like:

def test_members_excludes_fake_roles(self):
    i = self.instance.members(role='bogus-role-name')
    self.get_next(i)

    self.session.get.assert_called_once_with(
        # ...
        params={'per_page': 100},
        # ...
    )

Okay, just added some tests to ensure that a bogus role/filter isn't included in the request made to the API.

✨ 🍰 🎆 ✨ You're awesome @mwielgoszewski!