10909 postgresql dialect table options #12584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem to be the most useful table options to pass in most cases anyway. Reflects the implementation in PGDDLCompiler
Reflect dialect specific options passed to `Table` constructor Table options reflected: - postgresql_inherits - postgresql_with - postgresql_with_oids (in supported versions) - postgresql_using - postgresql_tablespace Fixes sqlalchemy#10909
|
Hi, I've given it a quick glance and great work so far. I'll try taking a better look this week |
- Add pg_tablespace, pg_inherits tables to pg_catalog (not committed originally) - Add test for table using non-default access method - Remove commented code - Correct formatting errors in docs
|
Cleaned up the implementation slightly, removing commented code and adding a simple test for a table using a non-default access method. Also, I didn't commit the tables I added to |
|
I'm interested in finishing this, so I'll keep it open |
sqla-tester
reviewed
Jun 18, 2025
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision c629f98 of this pull request into gerrit so we can run tests and reviews and stuff
|
Failed to create a gerrit review, git squash against branch 'main' failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
PGDialect.get_table_options,PGDialect.get_multi_table_optionsand attempts to properly reflect the following dialect specific options passed to theTableconstructorNo attempt was made to reflect
postgresql_partition_by, as the option is passed as a text string and would be difficult to replicate effectively (also, it's kind of useless without also reflectingpostgresql_partition_of, but I'd make an attempt at implementing declarative partitioning for postgres if there was interest.Also adds support for passing table storage parameters to
PGDDLCompiler.post_create_tableto the compiler.Fixes issue #10909
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!