In its current state zimports and mypy are fighting over what they want from https://github.com/sqlalchemy/sqlalchemy/pull/12645/files#diff-1e16143a522e36ab9806250b0ebee01057001cbd8d51d03db7336d9c8a762c0bR207-R209. Mypy wnats the #type: ignore comment on line 207 but zimports really does not like it that way and the changes it introduces create a syntax error

yes, zimports has some deficiencies with imports that require comments. usually I put the imports into a condtiional like "if True:" in the hopes of getting zimports to skip over them.

if we could improve zimports to maintain comments or have a more comprehensive "ignore" option that would solve other problems as well

usually I put the imports into a condtiional like "if True:" in the hopes of getting zimports to skip over them.

I saw a couple of comments referencing that and tried it, but no luck.

To be honest I started working on this before 68cd3e8 landed and it was "equally broken" on main and my branch.

yes, zimports has some deficiencies with imports that require comments. usually I put the imports into a condtiional like "if True:" in the hopes of getting zimports to skip over them.

if we could improve zimports to maintain comments or have a more comprehensive "ignore" option that would solve other problems as well

maybe we can try to fix zimports to bend it to our will?

actually there is sqlalchemyorg/zimports#43, let's try finishing that

I've pushed a change to zimports that should support this usecase sqlalchemyorg/zimports#47

Awesome! Should I test it with this PR? I sould be able to just edit the dep in tox.ini, right?

it's not yet released, once it is sure

it has been released as 0.6.2 if you want to try it