-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
React Native Web: Simplify config by using vite-plugin-rnw #32051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit 7e24f06
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 56 | 56 | 0 |
Self size | 41.36 MB | 41.35 MB | 🎉 -16 KB 🎉 |
Dependency size | 18.22 MB | 18.22 MB | 0 B |
Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
Before | After | Difference | |
---|---|---|---|
Dependency count | 161 | 163 | 🚨 +2 🚨 |
Self size | 35 KB | 32 KB | 🎉 -3 KB 🎉 |
Dependency size | 23.60 MB | 23.66 MB | 🚨 +61 KB 🚨 |
Bundle Size Analyzer | Link | Link |
sb
Before | After | Difference | |
---|---|---|---|
Dependency count | 57 | 57 | 0 |
Self size | 1 KB | 1 KB | 0 B |
Dependency size | 59.59 MB | 59.57 MB | 🎉 -16 KB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/cli
Before | After | Difference | |
---|---|---|---|
Dependency count | 221 | 221 | 0 |
Self size | 584 KB | 584 KB | 0 B |
Dependency size | 103.99 MB | 103.97 MB | 🎉 -16 KB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/codemod
Before | After | Difference | |
---|---|---|---|
Dependency count | 190 | 190 | 0 |
Self size | 31 KB | 31 KB | 0 B |
Dependency size | 88.08 MB | 88.06 MB | 🎉 -16 KB 🎉 |
Bundle Size Analyzer | Link | Link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing simplification! 🚀
493e3e5
to
e639acf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing changes made in this pull request
adcc4bf
to
b3f55ac
Compare
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
b3f55ac
to
7e24f06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @dannyhw !! This is a fantastic simplification.
Closes #
What I did
A problem with vite plugin react is that we can't do some of the module transforms we need to do because they completely block any node_modules from being transformed. This lead to the need for a babel plugin and the need for a separate set of config for what should be transformed essentially duplicating all the configuration and making it harder to use.
The rnw plugin I created takes the react plugin and adjusts it to better support react native web by allowing node_modules to be transformed, it also adds all the boilerplate crap that we need to make react native libraries believe we're ok to run on the web.
The main benefit in my mind is that the configuration becomes simplified
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-32051-sha-e639acf8
. Try it out in a new sandbox by runningnpx [email protected] sandbox
or in an existing project withnpx [email protected] upgrade
.More information
0.0.0-pr-32051-sha-e639acf8
dannyhw/feat/use-vite-plugin-rnw
e639acf8
1753025958
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=32051
Greptile Summary
This PR significantly simplifies the React Native Web configuration in Storybook by replacing multiple Vite plugins with a single unified
vite-plugin-rnw
. The key changes include:modulesToTranspile
option for better control over which node_modules packages get transformedpluginBabelOptions
in favor ofpluginReactOptions
This change addresses a fundamental limitation where Vite's plugin-react completely blocked node_modules from being transformed, which forced the use of duplicate configurations and separate babel plugins. The new plugin extends React's plugin functionality while adding proper support for React Native Web-specific requirements.
Confidence score: 4/5
6 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile