add support for v2 deleted objects #1543
Open
+88
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
helenye-stripe
and removed request for
a team
xavdid-stripe
changed the base branch from
sdk-release/next-major
to
sdk-releases/next-major
|
I'm peaceful with this but won't the generated changes get removed by CI since we'll go back to using the proto spec to generate the SDK? |
xavdid-stripe
changed the base branch from
sdk-releases/next-major
to
sdk-release/next-major
the manual changes won't. Plus I don't think we're running codegen against |
helenye-stripe
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The typing of delete calls has always been a little confusing in V1: SDKs say they return an entire object (like a
Customer) but with thedeletedproperty set toTrue. That's true for some APIs but not for others. For consistency, we just always say you get a "real" object.V2 APIs are more strict about the data they return: there's only ever
idandobject. To better represent this, we're now generating aV2.DeletedObjectclass that is returned from all v2 delete calls. This PR includes that generated class, but APIRequestor-related code to use it when appropreate.What?
_convert_to_stripe_objectSee Also
DEVSDK-2588