[DependencyInjection] Fix dumping containers with null-referenced services #52597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 15, 2023
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 7.0 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #52596 |
| License | MIT |
|
Why not adding a use statement with the other use statements in the file prolog instead of doing a dynamic constant access ? Wouldn't it be better for optimizations ? |
nicolas-grekas
force-pushed
the
di-fixup
branch
from
310c725 to
a70c5b3
Compare
|
Updated :) |
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
di-fixup
branch
from
a70c5b3 to
89f71ab
Compare
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2023
…erenced services (nicolas-grekas) This PR was merged into the 6.3 branch. Discussion ---------- [DependencyInjection] Fix dumping containers with null-referenced services | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52596 | License | MIT Backporting #52597 to 6.3 /cc `@connorhu` Commits ------- 45a5994 [DependencyInjection] Fix dumping containers with null-referenced services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.