Skip to content

add tests for base64 proposal #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 8, 2024
Merged

add tests for base64 proposal #3994

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bd05e23
add tests for base64 proposal
bakkot Jan 22, 2024
07807bd
fromBase64Into -> setFromBase64
bakkot Feb 8, 2024
911aa61
update detached buffer tests
bakkot Feb 8, 2024
6d7bd55
address ljharb comments
bakkot Mar 12, 2024
070d7ee
add tests that boxed strings are not valid values for options
bakkot Mar 12, 2024
44803f7
add test for excess padding
bakkot Mar 12, 2024
080c549
assert on the length of the backing buffer of the result
bakkot Mar 12, 2024
5132804
add TypedArray feature to all new tests
bakkot Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update detached buffer tests
  • Loading branch information
@bakkot @ljharb
bakkot authored and ljharb committed Feb 8, 2024
commit 911aa6173dd43cbe01b63ef396d58bd16e7e306c
15 changes: 7 additions & 8 deletions test/built-ins/Uint8Array/prototype/setFromBase64/detached-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-uint8array.prototype.setfrombase64
description: Uint8Array.prototype.setFromBase64 does not write to or error on detatched buffers
description: Uint8Array.prototype.setFromBase64 throws on detatched buffers
includes: [detachArrayBuffer.js]
features: [uint8array-base64]
---*/

var target = new Uint8Array([255, 255, 255]);
$DETACHBUFFER(target.buffer);
var result = target.setFromBase64('Zg==');
assert.sameValue(result.read, 0);
assert.sameValue(result.written, 0);
assert.throws(TypeError, function() {
target.setFromBase64('Zg==');
});

var getterCalls = 0;
var targetDetachingOptions = {};
Expand All @@ -23,7 +23,6 @@ Object.defineProperty(targetDetachingOptions, 'alphabet', {
}
});
var target = new Uint8Array([255, 255, 255]);
var result = target.setFromBase64('Zg==', targetDetachingOptions);
assert.sameValue(getterCalls, 1);
assert.sameValue(result.read, 0);
assert.sameValue(result.written, 0);
assert.throws(TypeError, function() {
target.setFromBase64('Zg==', targetDetachingOptions);
});
8 changes: 4 additions & 4 deletions test/built-ins/Uint8Array/prototype/setFromHex/detached-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-uint8array.prototype.setfromhex
description: Uint8Array.prototype.setFromHex does not write to or error on detatched buffers
description: Uint8Array.prototype.setFromHex throws on detatched buffers
includes: [detachArrayBuffer.js]
features: [uint8array-base64]
---*/

var target = new Uint8Array([255, 255, 255]);
$DETACHBUFFER(target.buffer);
var result = target.setFromHex('aa');
assert.sameValue(result.read, 0);
assert.sameValue(result.written, 0);
assert.throws(TypeError, function() {
target.setFromHex('aa');
});