Skip to content

feat: add encoding flag and automatically check if a file might be utf16 #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat: add encoding flag and automatically check if a file might be utf16 #2368

merged 1 commit into from
Jul 10, 2023

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Jul 4, 2023

From 1.0's checklist:

In parse command, auto-detect UTF-16 files and decode them accordingly. This will help windows users who currently trip over the suggested echo command in the docs.

@amaanq amaanq force-pushed the automate-utf16 branch 5 times, most recently from 0b94b1a to 7e09390 Compare July 4, 2023 03:58
@amaanq amaanq merged commit 9d669ab into tree-sitter:master Jul 10, 2023
@amaanq amaanq mentioned this pull request Jul 19, 2023
Open
29 tasks
@amaanq amaanq deleted the automate-utf16 branch August 2, 2023 14:14
@dundargoc dundargoc added this to the 1.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxbrunsfeld maxbrunsfeld maxbrunsfeld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amaanq @maxbrunsfeld @dundargoc