fix(bindings): correct indices for Node::utf16_text
#4619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We (I?) normally use the |
ribru17
reviewed
Jul 16, 2025
ribru17
approved these changes
Jul 22, 2025
clason
approved these changes
Aug 2, 2025
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node::utf16_textuses byte offsets to index into a slice ofu16s. These indices need to be adjusted.I added handling in case these adjusted indices happen to fall on a utf16 surrogate. I'm not sure how to construct such a pathological test case that has a node's text boundary split on a surrogate pair, but I think it's better to be safe than sorry in this case.
Alternatively, we could just use
String::from_utf16, however this would return owned data (also making the requisite heap allocation), as well as break parity withNode::utf8_text's return type.utf16_textindex out of range afterparse_utf16_lein Rust #4616