Skip to content

#12409 Correct example ('' -> b'' for root child name), and don't say "strings" where "bytes" are expected. #12410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2025
Merged

#12409 Correct example ('' -> b'' for root child name), and don't say "strings" where "bytes" are expected. #12410

merged 3 commits into from
Jan 2, 2025

Conversation

juanpeha
Copy link
Contributor

Scope and purpose

Fixes #12409

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #12410 will not alter performance

Comparing juanpeha:issue12409 (005bf3b) with trunk (067779a)

Summary

✅ 34 untouched benchmarks

adiroiban
adiroiban approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good. thanks!

@adiroiban adiroiban changed the title #12409: Correct example ('' -> b'' for root child name), and don't say "strings" where "bytes" are expected. #12409 Correct example ('' -> b'' for root child name), and don't say "strings" where "bytes" are expected. Jan 2, 2025
@adiroiban adiroiban merged commit 0315f0b into twisted:trunk Jan 2, 2025
28 checks passed
@juanpeha juanpeha deleted the issue12409 branch January 2, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
needs-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error in Twisted Web howto -- child names are bytes, not strings
3 participants
@juanpeha @adiroiban @chevah-robot