feat: tighten tsconfigRootDir validation
#11463
Conversation
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t lint |
❌ Failed | 3m 20s | View ↗ |
nx test eslint-plugin --coverage=false |
✅ Succeeded | 5m 6s | View ↗ |
nx run-many -t typecheck |
✅ Succeeded | 2m 16s | View ↗ |
nx test typescript-estree --coverage=false |
✅ Succeeded | 20s | View ↗ |
nx test eslint-plugin-internal --coverage=false |
✅ Succeeded | 11s | View ↗ |
nx run integration-tests:test |
✅ Succeeded | 6s | View ↗ |
nx run types:build |
✅ Succeeded | 5s | View ↗ |
nx run generate-configs |
✅ Succeeded | 8s | View ↗ |
Additional runs (23) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-08-18 15:19:07 UTC
Codecov Report❌ Patch coverage is Please upload reports for the commit 28aee27 to get more accurate results.
Additional details and impacted files@@ Coverage Diff @@
## main #11463 +/- ##
==========================================
+ Coverage 90.87% 90.88% +0.01%
==========================================
Files 505 505
Lines 51121 51142 +21
Branches 8415 8424 +9
==========================================
+ Hits 46455 46480 +25
+ Misses 4652 4648 -4
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
kirkwaiblinger
force-pushed
the
tsconfig-root-beer
branch
from
d151ca5 to
c3b9f4e
Compare
kirkwaiblinger
changed the title
tsconfigRootDir bugstsconfigRootDir validation
| (process.platform === 'win32' && | ||
| !/^[a-zA-Z]:/.test(userProvidedTsconfigRootDir)) |
There was a problem hiding this comment.
This is tested but it doesn't get picked up in the coverage report, due to only being tested on windows. Tried to use an istanbul ignore comment, but vitest/esbuild/typescript has problems with coverage ignore comments due to comment stripping and I couldn't get it to work :(
kirkwaiblinger
added
the
1 approval
kirkwaiblinger
changed the title
tsconfigRootDir validationtsconfigRootDir validation
PR Checklist
tsconfigRootDirs in tests #11414project: truedoesn't permit trailing pathsep intsconfigRootDir#11413tsconfigRootDiris provided #11460Overview
This ensures that tsconfigRootDir must always be absolute if provided. Adds testing. Adjusts existing testing which used relative tsconfigRootDirs rather than absolute.
Handles normalization so that trailing path sep bug is also solved (test included)