Update MSRV to 1.88 #8462
Draft
Update MSRV to 1.88 #8462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we moved to 1.88.0 MSRV, we can use that syntax.
Run `cargo +1.89.0 clippy --all-targets --all-features --tests --no-deps -pcoreutils -- -D warnings`
until it became happy.
This was useful, as `--fix` doesn't directly work on the command above:
ls src/uu/ | xargs -I{} cargo +1.89.0 clippy --all-targets --all-features --tests --no-deps -puu_{} --fix --allow-dirty -- -D warnings
|
GNU testsuite comparison: |
drinkcat
commented
Aug 11, 2025
|
GNU testsuite comparison: |
It does appear 0.2.37 is not supported by Rust 1.88.0
I found the suggested let-chain clunky, let's rework it.
We can just check if the value is Some(true).
|
GNU testsuite comparison: |
The let-chain made it more obvious that this could be simplified.
Now that let-chain are allowed, we can improve the code a little bit.
|
redoxer build is not happy, even after update to 0.2.54 (https://github.com/drinkcat/coreutils/actions/runs/16870133030/job/47783201524): I must say I'm totally unfamiliar with Redox... @jackpot51 is this something we can fix on coreutils' CI side? Or should we wait for a new release? |
1 task
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, lots of let-chains to replace.