Skip to content

feat(useCloned): return isModified #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 10, 2025
Merged

feat(useCloned): return isModified #4470

merged 9 commits into from
Jan 10, 2025

Conversation

pkc918
Copy link
Contributor

@pkc918 pkc918 commented Jan 7, 2025 •
edited
Loading

reference: #4393

Add a new isModifed feature to useCloned. This reactive attribute tracks whether the cloned value has been modified.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Jan 7, 2025
@pkc918 pkc918 changed the title feat(useCloned): return isCloneModified feat(useCloned): return isClonedModified Jan 7, 2025
OrbisK
OrbisK requested changes Jan 7, 2025
View reviewed changes
antfu
antfu reviewed Jan 8, 2025
View reviewed changes
@pkc918 pkc918 changed the title feat(useCloned): return isClonedModified feat(useCloned): return isModified Jan 8, 2025
@pkc918 pkc918 requested review from OrbisK and antfu January 8, 2025 13:40
@OrbisK
Copy link
Collaborator

OrbisK commented Jan 8, 2025

looks good so far. If you have the time, please consider adding some tests. 👍🏽

@pkc918
Copy link
Contributor Author

pkc918 commented Jan 8, 2025

looks good so far. If you have the time, please consider adding some tests. 👍🏽

Thx! Should the syntax of Vue3.5 be avoided? like pause & resume.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@pkc918
Copy link
Contributor Author

pkc918 commented Jan 8, 2025 •
edited
Loading

Hi，@OrbisK ！The unit tests have been supplemented. If you have time, I hope you can review them again. Thx a lot!

@OrbisK
Copy link
Collaborator

OrbisK commented Jan 8, 2025

looks good so far. If you have the time, please consider adding some tests. 👍🏽

Thx! Should the syntax of Vue3.5 be avoided? like pause & resume.

We have recently added the [email protected] syntax (toValue). I am not sure if we will drop [email protected] yet. But I think this use of pause and resume is pretty clean. I think Anthony will have an opinion on that 😄

OrbisK
OrbisK previously approved these changes Jan 8, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2025
@pkc918
Copy link
Contributor Author

pkc918 commented Jan 9, 2025 •
edited
Loading

looks good so far. If you have the time, please consider adding some tests. 👍🏽

Thx! Should the syntax of Vue3.5 be avoided? like pause & resume.

We have recently added the [email protected] syntax (toValue). I am not sure if we will drop [email protected] yet. But I think this use of pause and resume is pretty clean. I think Anthony will have an opinion on that 😄

OK! The syntax for Vue3.5 has been canceled. If I need to use it after future version updates, I will modify it then.

antfu
antfu reviewed Jan 10, 2025
View reviewed changes
@antfu antfu merged commit 6018c0e into vueuse:main Jan 10, 2025
7 of 8 checks passed
@OrbisK OrbisK mentioned this pull request Jan 22, 2025
Closed
4 tasks
@renovate renovate bot mentioned this pull request Apr 6, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@OrbisK OrbisK OrbisK left review comments

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Tasks Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkc918 @OrbisK @antfu