Skip to content

perf(useMutationObserver): watch ref directly #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Conversation

VividLemon
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

This watches the ref directly instead of the a function watching the value. Also removed the shadow variable name

Additional context

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 5, 2025
Copy link

pkg-pr-new bot commented Aug 5, 2025

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@4940

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@4940

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@4940

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@4940

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@4940

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@4940

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@4940

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@4940

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@4940

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@4940

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@4940

commit: bf16e31

@OrbisK
Copy link
Collaborator

OrbisK commented Aug 5, 2025

Hey, could you provide a link to a resource on the performance of getter functions vs refs?

@VividLemon
Copy link
Contributor Author

Hey, could you provide a link to a resource on the performance of getter functions vs refs?

It's more implicit, simply that the excess function invocation has performance overhead that watching the object does not incur.

@antfu antfu added this pull request to the merge queue Aug 6, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 6, 2025
Merged via the queue into vueuse:main with commit 01cd9cf Aug 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants