Skip to content

Trim VUCC_GRIDS Grids #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Trim VUCC_GRIDS Grids #1

merged 1 commit into from
Jan 16, 2024

Conversation

phl0
Copy link
Contributor

@phl0 phl0 commented Jan 15, 2024

As discovered by @DK9JC (see https://x.com/DK9JC/status/1745134799566651543?s=20) it can happen that VUCC_GRIDS are stored with whitespace between fields. This fixes calculation of distance as well as removes inner whitespace upon storing and editing such QSOs.

@phl0 phl0 self-assigned this Jan 15, 2024
@phl0 phl0 added the bug Something isn't working label Jan 15, 2024
HB9HIL pushed a commit that referenced this pull request Jan 16, 2024
@int2001
Copy link
Contributor

int2001 commented Jan 16, 2024

wouldn't it be good to put a catch if the grid is undefined/null on top?
sth. like $grid ?? ''?

@phl0
Copy link
Contributor Author

phl0 commented Jan 16, 2024

wouldn't it be good to put a catch if the grid is undefined/null on top? sth. like $grid ?? ''?

Tested with NULL and '' as values for GRIDSQUARE and VUCC_GRIDS. No errors.

@phl0 phl0 merged commit 16e8901 into wavelog:dev Jan 16, 2024
@phl0 phl0 deleted the trimVuccGrids branch January 16, 2024 10:13
HB9HIL referenced this pull request in HB9HIL/wavelog Feb 1, 2024
AndreasK79 added a commit that referenced this pull request Feb 4, 2024
 Prevent Racecondition when logging with CTRL-Enter
int2001 added a commit that referenced this pull request Feb 6, 2024
Also include SIG and SIG_INFO
HB9HIL pushed a commit that referenced this pull request Feb 6, 2024
phl0 added a commit that referenced this pull request Feb 6, 2024
phl0 pushed a commit that referenced this pull request Apr 7, 2024
HB9HIL added a commit that referenced this pull request Jun 7, 2024
phl0 pushed a commit that referenced this pull request Jul 8, 2024
responsive width and height classes
HB9HIL pushed a commit that referenced this pull request Aug 26, 2024
phl0 pushed a commit that referenced this pull request Jan 9, 2025
Apply time reset fix to end time as well
phl0 pushed a commit that referenced this pull request Jan 29, 2025
Value of constant should also be used in text message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants