-
Notifications
You must be signed in to change notification settings - Fork 70
[INSTALLER] Multilanguage Support for the Installer #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested with docker. 1st issue: Click on Language (at first page) and chose german: Redirects ultimate to |
Issue 1 and 3 are fixed with your latest commit. Repro for #2: Delete Cookies or use incognito-mode for calling the installer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works now as expected.
The first impression counts
Therefore it's just logical to support gettext and mutli languages in the installer aswell. As the installer is in the most parts independent from the main application I included the gettext lib in the installer aswell and adjusted it a bit.
The logic gets the default browser language and sets a cookie from it. So the user will directly see his native language (if everything is translated). He is still able to choose another language with a little button on the first page.
I will include the installer language as another component to our weblate platform