Skip to content

[INSTALLER] Multilanguage Support for the Installer #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jul 9, 2024

Conversation

HB9HIL
Copy link
Contributor

@HB9HIL HB9HIL commented Jul 9, 2024

The first impression counts

Therefore it's just logical to support gettext and mutli languages in the installer aswell. As the installer is in the most parts independent from the main application I included the gettext lib in the installer aswell and adjusted it a bit.

The logic gets the default browser language and sets a cookie from it. So the user will directly see his native language (if everything is translated). He is still able to choose another language with a little button on the first page.

I will include the installer language as another component to our weblate platform

@HB9HIL HB9HIL marked this pull request as ready for review July 9, 2024 08:25
@int2001
Copy link
Contributor

int2001 commented Jul 9, 2024

Tested with docker.

1st issue: Click on Language (at first page) and chose german: Redirects ultimate to http://127.0.0.1:8086/lang=de_DE/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/install/ and so on.
2nd issue: on first call it shows Warning: Undefined array key "install_lang" in /var/www/html/install/index.php on line 104
3rd issue: Continued with "english" as default-lang. When setup/migrations were finsished i see a german login-screen. after logging in my language is setted to Bulgarian

@int2001
Copy link
Contributor

int2001 commented Jul 9, 2024

Issue 1 and 3 are fixed with your latest commit.
issue 2 still there.

Repro for #2: Delete Cookies or use incognito-mode for calling the installer

Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now as expected.

@HB9HIL HB9HIL merged commit 8bd037d into wavelog:dev Jul 9, 2024
@HB9HIL HB9HIL deleted the gettext_installer branch July 9, 2024 12:32
@HB9HIL HB9HIL added the installer Stuff which affects the wavelog installer label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer Stuff which affects the wavelog installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants