Skip to content

[eQSL] only locations with a eQSL nickname should be displayed #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

dg0tm
Copy link
Contributor

@dg0tm dg0tm commented Feb 1, 2024

only locations with a eQSL nickname should be displayed in the dropdown under eQSL Import

@phl0
Copy link
Contributor

phl0 commented Feb 1, 2024

Not sure about this one tbh. The download link to the eqsl.cc inbox obviously downloads the entire eQSL inbox anyway. So it probably contains more than just the QSOs on the profiles linked to eQSL nicknames?!

@int2001
Copy link
Contributor

int2001 commented Feb 2, 2024

Agree with @phl0 - it doesn't have any effect since eQSL isn't taking care of that.
Would only affect the UI, but not the logic.
perhaps we should remove the station-chooser from eQSL completly and show the import only if there's at least one Station-location with eQSL-Nicknames set?

@dg0tm
Copy link
Contributor Author

dg0tm commented Feb 2, 2024

please see #73

and I believe the downloaded inbox only contains QSLs for or from the selected nickname. We were always confused when QSOs updated out of scope...

@int2001
Copy link
Contributor

int2001 commented Feb 2, 2024

and I believe the downloaded inbox only contains QSLs for or from the selected nickname. We were always confused when QSOs updated out of scope...

i just tried that. created a station_location with the same CALL but a different Nickname (fun fact: one that doesn't exist at eQSL).

eQSL-Endpoint is downloading/fetching ALL eQSLs and doesn't take care of the Nick when fetching the eQSLs. The "Nickname" is passed to eQSL, but eQSL ignores it.

And yea: that's a problem that has to be fixed at eQSL

@dg0tm
Copy link
Contributor Author

dg0tm commented Feb 2, 2024

I also checked it again and it works as expected. Only the QSOs of the corresponding nickname are included
in the downloaded file.

Keep in mind that eQSL requires you to specify different time periods per nickname.

eQSL works differently :)

@HB9HIL
Copy link
Contributor

HB9HIL commented Feb 2, 2024

error

There is missing an error handler if no station has an eQSL Nickname

Copy link
Contributor

@HB9HIL HB9HIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an error handler if no station has an eQSL Nickname

int2001

This comment was marked as outdated.

@dg0tm
Copy link
Contributor Author

dg0tm commented Feb 2, 2024

Okay, I took a first look at it and it is not triggered by this patch.

Should I patch this in another PR or with this one?

@HB9HIL
Copy link
Contributor

HB9HIL commented Feb 2, 2024

Okay, I took a first look at it and it is not triggered by this patch.

Should I patch this in another PR or with this one?

You can add the error handler in this PR

@HB9HIL
Copy link
Contributor

HB9HIL commented Feb 2, 2024

Okay, I took a first look at it and it is not triggered by this patch.

Should I patch this in another PR or with this one?

And it seems like this bug was already there. But I would be awesome if you can add this aswell 😆

@dg0tm
Copy link
Contributor Author

dg0tm commented Feb 2, 2024

quick & dirty patch via flash message

i also add 2 lines for better knowledge off witch button belongs to which function at all

@dg0tm
Copy link
Contributor Author

dg0tm commented Feb 2, 2024

eQSL-Nickname_not_defined

@dg0tm
Copy link
Contributor Author

dg0tm commented Feb 2, 2024

eQSL-usability

by switching the order, it is much more intuitive

@HB9HIL HB9HIL merged commit bd4ab30 into wavelog:dev Feb 2, 2024
HB9HIL referenced this pull request in HB9HIL/wavelog Feb 5, 2024
* Added Windows, MariaDB and PHP-Versions

* Release 1.0

* Re-added forum link

* add stations_id to eqsl functions

* remove 'v' in Version Dialog

* Update README.md

added Link to demo instance

* Update index.php

* We should be MIT Conform

* [Debug] Added information about when files were last updated, and links to update

* Added custom data format

* Remove leftover-index

* Migration

* Check if index is there

* [LBA] Can disable maidenhead overlay

* [eQSL] only locations with a eQSL nickname should be displayed (#74)

* only locations with a eQSL nickname should be displayed in the dropdown under eQSL Import

* add proper error message

* improve usability

---------

Co-authored-by: Christoph Kottke <[email protected]>

* html fixes

* show flashdata if no station has eqsl nick

* removed openssl check, not required

* accumulate stats language

* multilanguage support

* prettier

* Prevent leaking data out of other station_location

* moved qrg to first tab

* Fix a PHP 8.1 deprecated bug.

* [Contesting] Fix for table qso count

* Fixed error when data was empty. Also clear table before inserting again.

* Refactor to get the table to load

* Need to clear datatable when session is deleted

* Prevent Racecondition

* Fixed a few null-checks which will fail on fresh accounts

* Allow for longer gridsquare in station profile

* Show IOTA/SOTA ref on station location tab

* [LBA] Fixed mapping of selected QSOs

---------

Co-authored-by: int2001 <[email protected]>
Co-authored-by: Joerg (DJ7NT) <[email protected]>
Co-authored-by: Andreas <[email protected]>
Co-authored-by: Christoph Kottke <[email protected]>
Co-authored-by: Florian (DF2ET) <[email protected]>
Co-authored-by: dg0tm <[email protected]>
@dg0tm dg0tm deleted the eqsl branch February 5, 2024 20:57
HB9HIL added a commit that referenced this pull request Feb 9, 2024
* config file for directory userdata

* userdir for eqsl

* change name to userdata

* userdata for qsl

* fix name on comment

* add generic function file

* remove model class on view, use generic function

* Re-added forum link

* add stations_id to eqsl functions

* remove 'v' in Version Dialog

* Update README.md

added Link to demo instance

* Update index.php

* We should be MIT Conform

* [Debug] Added information about when files were last updated, and links to update

* Added custom data format

* Remove leftover-index

* Migration

* Check if index is there

* [LBA] Can disable maidenhead overlay

* paths libary

* Dev (#2)

* Added Windows, MariaDB and PHP-Versions

* Release 1.0

* Re-added forum link

* add stations_id to eqsl functions

* remove 'v' in Version Dialog

* Update README.md

added Link to demo instance

* Update index.php

* We should be MIT Conform

* [Debug] Added information about when files were last updated, and links to update

* Added custom data format

* Remove leftover-index

* Migration

* Check if index is there

* [LBA] Can disable maidenhead overlay

---------

Co-authored-by: int2001 <[email protected]>
Co-authored-by: Joerg (DJ7NT) <[email protected]>
Co-authored-by: Andreas <[email protected]>
Co-authored-by: Christoph Kottke <[email protected]>
Co-authored-by: Florian (DF2ET) <[email protected]>

* [eQSL] only locations with a eQSL nickname should be displayed (#74)

* only locations with a eQSL nickname should be displayed in the dropdown under eQSL Import

* add proper error message

* improve usability

---------

Co-authored-by: Christoph Kottke <[email protected]>

* html fixes

* show flashdata if no station has eqsl nick

* removed openssl check, not required

* accumulate stats language

* multilanguage support

* prettier

* Prevent leaking data out of other station_location

* moved qrg to first tab

* Fix a PHP 8.1 deprecated bug.

* [Contesting] Fix for table qso count

* Fixed error when data was empty. Also clear table before inserting again.

* Refactor to get the table to load

* Need to clear datatable when session is deleted

* Prevent Racecondition

* Fixed a few null-checks which will fail on fresh accounts

* Allow for longer gridsquare in station profile

* Show IOTA/SOTA ref on station location tab

* [LBA] Fixed mapping of selected QSOs

* Trying to convert the QSO-Post to an ajax call PHP/Part

* JS Part

* Dev (#3)

* Added Windows, MariaDB and PHP-Versions

* Release 1.0

* Re-added forum link

* add stations_id to eqsl functions

* remove 'v' in Version Dialog

* Update README.md

added Link to demo instance

* Update index.php

* We should be MIT Conform

* [Debug] Added information about when files were last updated, and links to update

* Added custom data format

* Remove leftover-index

* Migration

* Check if index is there

* [LBA] Can disable maidenhead overlay

* [eQSL] only locations with a eQSL nickname should be displayed (#74)

* only locations with a eQSL nickname should be displayed in the dropdown under eQSL Import

* add proper error message

* improve usability

---------

Co-authored-by: Christoph Kottke <[email protected]>

* html fixes

* show flashdata if no station has eqsl nick

* removed openssl check, not required

* accumulate stats language

* multilanguage support

* prettier

* Prevent leaking data out of other station_location

* moved qrg to first tab

* Fix a PHP 8.1 deprecated bug.

* [Contesting] Fix for table qso count

* Fixed error when data was empty. Also clear table before inserting again.

* Refactor to get the table to load

* Need to clear datatable when session is deleted

* Prevent Racecondition

* Fixed a few null-checks which will fail on fresh accounts

* Allow for longer gridsquare in station profile

* Show IOTA/SOTA ref on station location tab

* [LBA] Fixed mapping of selected QSOs

---------

Co-authored-by: int2001 <[email protected]>
Co-authored-by: Joerg (DJ7NT) <[email protected]>
Co-authored-by: Andreas <[email protected]>
Co-authored-by: Christoph Kottke <[email protected]>
Co-authored-by: Florian (DF2ET) <[email protected]>
Co-authored-by: dg0tm <[email protected]>

* First POC

* Handling of AJAX result (started)

* Change qso-save to ajax-return

* Added notification and reloading of QSO-Table

* JS-Part

* Set Focus to qso after (successful) log

* Resetting timers (successful)

* Info is now shown / faded

* Small adjustments

* More Beauty

* Make consequent use of SIG-References from station_profile

* Delete application/views/welcome directory

Leftovers. Security Flaw!

* Update Dashboard.php

Remove redir to welcome

* Delete application/controllers/Welcome.php

security flaw

* Hint for 8.3. friendly Usertest

* Update config.sample.php

default should be commented out

* [LBA] Checkbox to turn on/off path lines in map

* Styling for pathlines-checkbox

* [LBA] Checkbox tweaks

* updated comment in config.php (sample and installer)

* Removed popup regarding unsaved changes (wasn't functional at all)

* Added locking for sending a qso twice

* added spinner to save button

* Also include SIG and SIG_INFO

* [Logbook] Removed profiler

* [LBA] Added fitbounds to map

* [LBA] Added CQ Zone overlay

* Make clearer that overview filters on logbook rather than locations

* baesURL has a trailing slash already

* active logbook hint

* Update .gitignore

added userdata

* [LBA] ITU zone overlay

* Minor wording

* [LBA] Added custom mapping icons

* [LBA] Path line follows icon color

* [LBA] Added icon anchoring

* [LBA] Added easyprint for easy map saving

* [LBA] Added default colors when icon settings does not exist in db

* Check refs before trimming them

* [LBA] Fixed another default issue with markers and colors

* Removed dangerous functions where User can accidently shift profiles

* Rmoeve more unused leftovers from 1.0 to 2.0.

* Header refactoring (#110)

* splitted up header

* resorted header menu

* main rebuild

* header behaviour hover

* dropdown toggle rotate

* fix case where landscape is small menu and portrait normal view

* submenu thirdparty services

* removed custom maps from the header

* matching search bar

* border

* matched border to themes

* [Custom Map] Removed code

* [Gridmap] Broke map by accident. Thanks @phl0 for poke.

* Optical support for SAT directions and elevation

* [LBA] Added coordinates at the bottom of the map

* Align numbers and arrows

* Reset RST after saving via AJAX

* Cfd export (#117)

* Added CFD Export for toplist.darc.de to Wavelog

---------

Co-authored-by: phl0 <[email protected]>

* special thx to contributors

* tag 1.1

* typo

---------

Co-authored-by: abarrau <[email protected]>
Co-authored-by: Andreas <[email protected]>
Co-authored-by: Christoph Kottke <[email protected]>
Co-authored-by: Joerg (DJ7NT) <[email protected]>
Co-authored-by: int2001 <[email protected]>
Co-authored-by: Florian (DF2ET) <[email protected]>
Co-authored-by: dg0tm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants