nv2a: Implement SET_LINE_WIDTH #2291
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mborgerson
force-pushed
the
feat/line-width
branch
from
602037f to
92d2e9e
Compare
mborgerson
force-pushed
the
feat/line-width
branch
from
92d2e9e to
58fcee1
Compare
mborgerson
commented
Jun 23, 2025
| @@ -1532,6 +1523,14 @@ DEF_METHOD(NV097, SET_SHADE_MODE) | |||
| } | |||
| } | |||
|
|
|||
| DEF_METHOD(NV097, SET_LINE_WIDTH) | |||
| { | |||
| if (parameter < 0x200) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward implementation of line width support. Line widths are clamped to device limits. In the future we'll replace device dependent line-width rendering with a custom rasterization pass, but this is step in the right direction.
FIXME:
Closes #698