Skip to content
This repository was archived by the owner on Jun 27, 2025. It is now read-only.

fix(test): e2e test is failing in main branch #430

Merged
merged 3 commits into from
Jul 1, 2021
Merged

fix(test): e2e test is failing in main branch #430

merged 3 commits into from
Jul 1, 2021

Conversation

sumitparakh
Copy link
Contributor

Closes #429

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #429

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@nx-cloud
Copy link

nx-cloud bot commented Jun 29, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit ff15ae8. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected:build --base=origin/main --head=HEAD --parallel --with-deps
#000000 nx affected:e2e --base=origin/main --head=HEAD --parallel --with-deps
#000000 nx affected:lint --base=origin/main --head=HEAD --parallel
#000000 nx affected:test --base=origin/main --head=HEAD --parallel --with-deps

Sent with 💌 from NxCloud.

Jefiozie
Jefiozie suggested changes Jun 29, 2021
View reviewed changes
Copy link
Member

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sumitparakh, could you have a look why the test is failing? Thanks

@sumitparakh
Copy link
Contributor Author

Sure

@sumitparakh
Copy link
Contributor Author

@Jefiozie . It is fixed.

Jefiozie
Jefiozie approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jefiozie Jefiozie merged commit 52078b7 into xlayers:main Jul 1, 2021
@sumitparakh sumitparakh deleted the sumitparakh/issue429 branch July 1, 2021 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jefiozie Jefiozie Jefiozie approved these changes

@manekinekko manekinekko Awaiting requested review from manekinekko manekinekko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e test is failing in main branch
2 participants
@sumitparakh @Jefiozie