Further clean up the topic list filtering typeahead logic. #35485
+95
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of search_pill. Fixes part of zulip#35284.
This commit adds the `data-syntax` attribute for `get_typeahead_search_term` to determine the appropriate filtering logic , rather than relying on plain text or strings. Additionally, this fix restores the use of the description label instead of the syntax when displaying the pills. Fixes part of zulip#35284.
shuklamaneesh23
force-pushed
the
resolved-cleanup
branch
from
2f82175 to
a0751b0
Compare
|
@zulipbot add "buddy review" |
zulipbot
added
mentor review
|
Hey @alya, could you please take a look at it and let me know if the text on the pill now looks good to you? |
|
Will look into soon. |
timabbott
reviewed
Jul 29, 2025
| @@ -1,4 +1,4 @@ | |||
| <div class='pill {{#if deactivated}} deactivated-pill {{/if}}'{{#if user_id}}data-user-id="{{user_id}}"{{/if}}{{#if group_id}}data-user-group-id="{{group_id}}"{{/if}}{{#if stream_id}}data-stream-id="{{stream_id}}"{{/if}} tabindex=0> | |||
| <div class='pill {{#if deactivated}} deactivated-pill {{/if}}'{{#if user_id}}data-user-id="{{user_id}}"{{/if}}{{#if group_id}}data-user-group-id="{{group_id}}"{{/if}}{{#if stream_id}}data-stream-id="{{stream_id}}"{{/if}}{{#if data_syntax}}data-syntax="{{data_syntax}}"{{/if}} tabindex=0> | |||
There was a problem hiding this comment.
Probably we should be line-wrapping this so each if/else clause for data fields is on its own line.
timabbott
reviewed
Jul 29, 2025
| @@ -484,8 +484,11 @@ export function get_left_sidebar_topic_search_term(): string { | |||
|
|
|||
| export function get_typeahead_search_term(): string { | |||
There was a problem hiding this comment.
This function name should probably be get_typeahead_search_pills_syntax or something.
This also seems very wrong as code if there's ever multiple pills. I guess that's not possible for now, but it's a code smell for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several improvements related to how pills are implemented and displayed:
search_pillwith a minimal wrapper module (topic_filter_pill.ts), similar to the approach used inweb/src/integration_branch_pill.ts.get_typeahead_search_termto usedata-syntaxattribute instead of relying on text/string matching to determine filtering logic.Fixes part of: #35284.
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: