fix(core): Fixed InputBinding behavior when a property set to @Input and cdr strategy OnPush #62613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
requested review from
crisbeto and
atscott
and removed request for
thePunderWoman
atscott
approved these changes
Jul 14, 2025
JeanMeche
added
target: patch
|
Can you please make sure to add a commit body, Thank you. |
This fix ensures that CD runs on OnPush component when an input binding is set.
JeanMeche
force-pushed
the
fix-issue-62343
branch
from
5b6dc93 to
800f748
Compare
JeanMeche
added
action: merge
|
This PR was merged into the repository by commit 780774f. The changes were merged into the following branches: main, 20.1.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 14, 2025
This fix ensures that CD runs on OnPush component when an input binding is set. PR Close #62613
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
inputBinding to bind to an old-style @input() property of an OnPush component doesn't mark the component for check and therefore never updates the template of that component.
Issue Number: #62343
What is the new behavior?
Fixed InputBinding behavior when a property set to @input and a component with cdr strategy set to OnPush would never update the component view
Does this PR introduce a breaking change?