Skip to content

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The diagnostic was displaying 'Function in text interpolation should be invoked: ect Object]()

What is the new behavior?

The diagnostic displays `'Function in text interpolation should be invoked: firstName()'.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from atscott July 27, 2025 17:21
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Jul 27, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 27, 2025
@JoostK
Copy link
Member

JoostK commented Jul 28, 2025

'Function in text interpolation should be invoked: ect Object]()

This seems to indicate a larger problem at play, where the original source seems to have been [object Object]?

The diagnostic was displaying `'Function in text interpolation should be invoked: ect Object]()` instead of `'Function in text interpolation should be invoked: firstName()'.
@cexbrayat cexbrayat force-pushed the fix/ng8117-message branch from a713ebd to c60f3bb Compare July 28, 2025 09:52
@cexbrayat
Copy link
Member Author

@JoostK @JeanMeche I removed the source.toString() call to only rely on expression.name

Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@JoostK JoostK added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit target: patch This PR is targeted for the next patch release labels Jul 29, 2025
@thePunderWoman thePunderWoman added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 29, 2025
@thePunderWoman thePunderWoman removed the request for review from atscott July 29, 2025 16:49
@thePunderWoman thePunderWoman removed the action: presubmit The PR is in need of a google3 presubmit label Jul 29, 2025
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit c491707.

The changes were merged into the following branches: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants