feat(@schematics/angular): Applications are zoneless by default #30718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
atscott
added
target: major
atscott
force-pushed
the
zonelessdefaultv21
branch
from
b381f6b to
2381fc4
Compare
angular-robot
bot
added
detected: feature
atscott
force-pushed
the
zonelessdefaultv21
branch
from
2381fc4 to
79d6d09
Compare
atscott
force-pushed
the
zonelessdefaultv21
branch
4 times, most recently
from
ea4fb06 to
1a2767a
Compare
atscott
force-pushed
the
zonelessdefaultv21
branch
9 times, most recently
from
4b1459a to
1e10964
Compare
atscott
commented
Sep 18, 2025
| @NgModule({ | ||
| providers: [typeof window.Zone !== 'undefined' ? provideZoneChangeDetection() : []], | ||
| }) | ||
| class TestModule {} |
There was a problem hiding this comment.
Do I need to avoid the @NgModule here and use compileNgModuleDefs instead like in the karma/browser_builder?
Same question for karma/application_builder.ts web-test-runner/jasmine_runner.js
There was a problem hiding this comment.
I think these are fine when using esbuild.
atscott
force-pushed
the
zonelessdefaultv21
branch
from
1e10964 to
dce2fad
Compare
This change updates applications to omit the ZoneJS dependency by default. This change also includes the addition of `provideZoneChangeDetection` in the `initTestEnvironment` when ZoneJS is detected in the configuration (either on window or in the polyfills).
atscott
force-pushed
the
zonelessdefaultv21
branch
from
dce2fad to
d7d946a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates applications to omit the ZoneJS dependency by
default.
This change also includes the addition of
provideZoneChangeDetectionin the
initTestEnvironmentwhen ZoneJS is detected in theconfiguration (either on window or in the polyfills).