feat: Corner Smoothing CSS rule #45185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavin
force-pushed
the
clavin/corner-smoothing
branch
from
30be714 to
5436ddc
Compare
clavin
force-pushed
the
clavin/corner-smoothing
branch
from
d32ff93 to
8a44af0
Compare
clavin
force-pushed
the
clavin/corner-smoothing
branch
from
c35494d to
17224b1
Compare
clavin
added
semver/minor
jkleinsc
reviewed
Feb 18, 2025
electron-cation
bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
patches/chromium/feat_corner_smoothing_css_rule_and_blink_painting.patch
Show resolved
Hide resolved
patches/chromium/feat_corner_smoothing_css_rule_and_blink_painting.patch
Show resolved
Hide resolved
|
The patch has now drifted, so I'm working on getting it back in sync with main. |
The patch went from 694 lines to 505 lines, which is a 27.2% smaller!
|
✅ Updated the patch to address upstream changes, allowing me to cut out 27.2% (a quarter!) of the changes. |
samuelmaddock
approved these changes
Mar 12, 2025
patches/chromium/feat_corner_smoothing_css_rule_and_blink_painting.patch
Show resolved
Hide resolved
jkleinsc
approved these changes
Mar 24, 2025
|
Release Notes Persisted
|
|
This breaks the
|
|
@reitowo yep, I came here to check in because I'm seeing the same. I'll TAL |
|
Since this is breaking all Some of the conflicts are just normal context shear, so I started to make a PR to fix that. But there are some new upstream changes that conflict with the patch and are directly relevant, e.g. the changes to how CC @clavin |
codebytere
pushed a commit
that referenced
this pull request
Mar 24, 2025
clavin
added a commit
that referenced
this pull request
Mar 25, 2025
ckerr
pushed a commit
that referenced
this pull request
Mar 31, 2025
* feat: Corner Smoothing CSS rule (Reland) Reland of #45185 * Fix patch conflicts * fixup! Fix patch conflicts * Update expected image The dashed border is subtly different. The new version is correct and the old one was incorrect.
trop bot
added a commit
that referenced
this pull request
Mar 31, 2025
Reland of #45185 Co-authored-by: Calvin <[email protected]>
ckerr
pushed a commit
that referenced
this pull request
Apr 1, 2025
* feat: Corner Smoothing CSS rule (Reland) Reland of #45185 Co-authored-by: Calvin <[email protected]> * Fix patch conflicts Co-authored-by: clavin <[email protected]> * fixup! Fix patch conflicts Co-authored-by: clavin <[email protected]> * Update expected image The dashed border is subtly different. The new version is correct and the old one was incorrect. Co-authored-by: clavin <[email protected]> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Calvin <[email protected]> Co-authored-by: clavin <[email protected]>
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
* feat: Corner Smoothing * Patch Blink to add CSS rule and Painting * Add `system-ui` keyword * Add `cornerSmoothingCSS` web preference * Add tests * Documentation * fixup! Documentation * fix: initialize smoothness value * Use a 1.0 scale factor in tests * Fix tests for CI * Fix tests * fixup! Merge branch 'main' into clavin/corner-smoothing * Add code docs * Document `system-ui` keyword values * Address review comments * fixup! Address review comments * Address review comments * Update patch to address upstream changes The patch went from 694 lines to 505 lines, which is a 27.2% smaller! * fixup! Update patch to address upstream changes
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
Revert "feat: Corner Smoothing CSS rule (electron#45185)" This reverts commit b75e802.
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
* feat: Corner Smoothing CSS rule (Reland) Reland of electron#45185 * Fix patch conflicts * fixup! Fix patch conflicts * Update expected image The dashed border is subtly different. The new version is correct and the old one was incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for RFC 12: Corner Smoothing.
In this PR
-electron-corner-smoothingenableCornerSmoothingCSSNotes: Added a CSS rule for smooth corners.