Skip to content

plumbing: check setAuth error. Fixes #185 #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023
Merged

plumbing: check setAuth error. Fixes #185 #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
plumbing: check setAuth error. Fixes #185
  • Loading branch information
@nodivbyzero
nodivbyzero committed Dec 14, 2023
commit ced1b81e32f971a80e474e9661b9c1b9c96569e7
4 changes: 3 additions & 1 deletion plumbing/transport/ssh/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ type runner struct {
func (r *runner) Command(cmd string, ep *transport.Endpoint, auth transport.AuthMethod) (common.Command, error) {
c := &command{command: cmd, endpoint: ep, config: r.config}
if auth != nil {
c.setAuth(auth)
if err := c.setAuth(auth); err != nil {
return nil, err
}
}

if err := c.connect(); err != nil {
Expand Down
23 changes: 23 additions & 0 deletions plumbing/transport/ssh/common_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,3 +206,26 @@ func (c *mockSSHConfig) Get(alias, key string) string {

return a[key]
}

type invalidAuthMethod struct {
}

func (a *invalidAuthMethod) Name() string {
return "invalid"
}

func (a *invalidAuthMethod) String() string {
return "invalid"
}

func (s *SuiteCommon) TestCommandWithInvalidAuthMethod(c *C) {
uploadPack := &UploadPackSuite{}
uploadPack.SetUpSuite(c)
r := &runner{}
auth := &invalidAuthMethod{}

_, err := r.Command("command", uploadPack.newEndpoint(c, "endpoint"), auth)

c.Assert(err, NotNil)
c.Assert(err, ErrorMatches, "invalid auth method")
}