Adjust testPresignedPostPolicy to ensure that GetObject... by marktheunissen · Pull Request #1996 · minio/minio-go

marktheunissen · 2024-09-02T07:05:42Z

...returns the correct checksum.

Add checksum policy conditions to SetChecksum() function of Policy
Add Content-Encoding to test
Add a new test testPresignedPostPolicyWrongFile to validate Checksums check negative case
Linting fixes and general cruft cleanup

For the following issue: minio/minio#20343

Related PR: minio/minio#20674

marktheunissen · 2024-09-02T07:15:32Z

functional_tests.go

-		logError(testName, function, args, startTime, "", "PutObject failed", err)
-		return
-	}
-


I think this was just a copy paste mistake, not sure why we were doing a PutObject here, as we are running the PostPolicy presigned request via the http client further down.

post-policy.go

marktheunissen · 2024-09-24T06:12:07Z

FYI to myself: minio/minio#18074 (comment)

marktheunissen · 2024-11-20T06:24:37Z

Converted to draft temporarily while I complete the MinIO side.

retry.go

post-policy.go

marktheunissen · 2024-11-21T02:24:24Z

functional_tests.go

-
 	policy := minio.NewPostPolicy()
-
-	if err := policy.SetBucket(""); err == nil {


I moved these negative tests into post-policy_test.go, and then added some more test cases in that file.

marktheunissen · 2024-11-21T02:26:01Z

functional_tests.go

+		return
+	}
+
+	// Ensure that when we subsequently GetObject, the checksum is returned


This was the original user request - to have the checksum value returned when doing a GetObject, after doing a Post Policy. That functionality was already merged in MinIO weeks ago so this just adds the test for it.

marktheunissen · 2024-11-21T02:26:40Z

functional_tests.go

 	}

-	// Seed random based on current time.
-	rand.Seed(time.Now().Unix())


Deprecated, we can remove this call from every test, I might make a follow up PR to do the rest.

marktheunissen · 2024-11-21T02:52:13Z

@klauspost ready for a re-review when you get a moment :)

…orrect checksum. Add checksum headers to policy

…omment

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) | require | patch | `v7.0.78` -> `v7.0.83` | --- ### Release Notes <details> <summary>minio/minio-go (github.com/minio/minio-go/v7)</summary> ### [`v7.0.83`](minio/minio-go@v7.0.82...v7.0.83) [Compare Source](minio/minio-go@v7.0.82...v7.0.83) ### [`v7.0.82`](https://github.com/minio/minio-go/releases/tag/v7.0.82): Bugfix Release [Compare Source](minio/minio-go@v7.0.81...v7.0.82) #### What's Changed - sts: Send the refresh token in the login redirect URL by [@vadmeste](https://github.com/vadmeste) in minio/minio-go#2025 - Fix duplicate API call on `obj.Stat()` by [@OrkhanAlikhanov](https://github.com/OrkhanAlikhanov) in minio/minio-go#2028 - Fix for tests running in mint vs locally by [@marktheunissen](https://github.com/marktheunissen) in minio/minio-go#2029 - Add Full Object Checksum API by [@klauspost](https://github.com/klauspost) in minio/minio-go#2026 - Read ChecksumAlgorithm and ChecksumType from ListParts by [@klauspost](https://github.com/klauspost) in minio/minio-go#2032 - Bump golang.org/x/crypto from 0.28.0 to 0.31.0 in /examples/s3 by [@dependabot](https://github.com/dependabot) in minio/minio-go#2033 #### New Contributors - [@OrkhanAlikhanov](https://github.com/OrkhanAlikhanov) made their first contribution in minio/minio-go#2028 **Full Changelog**: minio/minio-go@v7.0.81...v7.0.82 ### [`v7.0.81`](https://github.com/minio/minio-go/releases/tag/v7.0.81): Bugfix Release [Compare Source](minio/minio-go@v7.0.80...v7.0.81) #### What's Changed - PromptObject API support by [@sidharthrajaram](https://github.com/sidharthrajaram) in minio/minio-go#2015 - Fix new lint errors by [@klauspost](https://github.com/klauspost) in minio/minio-go#2020 - functional tests: move client creation into a reusable function by [@marktheunissen](https://github.com/marktheunissen) in minio/minio-go#2022 - Adjust testPresignedPostPolicy to ensure that GetObject... by [@marktheunissen](https://github.com/marktheunissen) in minio/minio-go#1996 - Add refresh token to WebIdentity OpenID response by [@vadmeste](https://github.com/vadmeste) in minio/minio-go#2023 #### New Contributors - [@sidharthrajaram](https://github.com/sidharthrajaram) made their first contribution in minio/minio-go#2015 **Full Changelog**: minio/minio-go@v7.0.80...v7.0.81 ### [`v7.0.80`](https://github.com/minio/minio-go/releases/tag/v7.0.80): Bugfix Release [Compare Source](minio/minio-go@v7.0.79...v7.0.80) #### What's Changed - Add support for AllVersionsExpiration ilm rule by [@dhananjaykrutika](https://github.com/dhananjaykrutika) in minio/minio-go#2014 - retry: make max retries configurable by [@ashwanthgoli](https://github.com/ashwanthgoli) in minio/minio-go#2013 #### New Contributors - [@dhananjaykrutika](https://github.com/dhananjaykrutika) made their first contribution in minio/minio-go#2014 - [@ashwanthgoli](https://github.com/ashwanthgoli) made their first contribution in minio/minio-go#2013 **Full Changelog**: minio/minio-go@v7.0.79...v7.0.80 ### [`v7.0.79`](https://github.com/minio/minio-go/releases/tag/v7.0.79): Bugfix Release [Compare Source](minio/minio-go@v7.0.78...v7.0.79) #### What's Changed - Update remove bucket replication reference by [@emmanuel-ferdman](https://github.com/emmanuel-ferdman) in minio/minio-go#2006 - Only retry multi-part upload as single-part upload on GCS endpoints by [@ramondeklein](https://github.com/ramondeklein) in minio/minio-go#2012 #### New Contributors - [@emmanuel-ferdman](https://github.com/emmanuel-ferdman) made their first contribution in minio/minio-go#2006 **Full Changelog**: minio/minio-go@v7.0.78...v7.0.79 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Gusted <postmaster@gusted.xyz> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6479 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>

marktheunissen mentioned this pull request Sep 2, 2024

Store the checksum in PostPolicyHandler so that we can return it on G… minio/minio#20364

Merged

8 tasks

marktheunissen changed the title ~~Adjust testPresignedPostPolicy to ensure that GetObject returns the correct checksum. Add checksum headers to policy~~ Adjust testPresignedPostPolicy to ensure that GetObject... Sep 2, 2024

marktheunissen force-pushed the checksumpostpolicy branch from df3d6c9 to 5de5dbe Compare September 2, 2024 07:13

marktheunissen commented Sep 2, 2024

View reviewed changes

post-policy.go Outdated Show resolved Hide resolved

klauspost reviewed Sep 5, 2024

View reviewed changes

post-policy.go Outdated Show resolved Hide resolved

marktheunissen force-pushed the checksumpostpolicy branch from 5de5dbe to cf2b561 Compare September 24, 2024 01:19

marktheunissen force-pushed the checksumpostpolicy branch from cf2b561 to 301e5dc Compare November 20, 2024 06:22

marktheunissen marked this pull request as draft November 20, 2024 06:24

marktheunissen force-pushed the checksumpostpolicy branch 3 times, most recently from fee2c7b to efc148e Compare November 21, 2024 02:19

marktheunissen commented Nov 21, 2024

View reviewed changes

retry.go Outdated Show resolved Hide resolved

marktheunissen commented Nov 21, 2024

View reviewed changes

post-policy.go Outdated Show resolved Hide resolved

marktheunissen commented Nov 21, 2024

View reviewed changes

marktheunissen force-pushed the checksumpostpolicy branch from efc148e to 7289296 Compare November 21, 2024 02:27

marktheunissen mentioned this pull request Nov 21, 2024

Fixes for POST policy checks and the x-ignore implementation minio/minio#20674

Merged

8 tasks

marktheunissen marked this pull request as ready for review November 21, 2024 02:48

marktheunissen requested a review from klauspost November 21, 2024 02:51

marktheunissen force-pushed the checksumpostpolicy branch 2 times, most recently from 6ce6043 to 913700e Compare November 21, 2024 23:01

harshavardhana approved these changes Nov 21, 2024

View reviewed changes

Adjust testPresignedPostPolicy to ensure that GetObject returns the c…

49125e9

…orrect checksum. Add checksum headers to policy

marktheunissen force-pushed the checksumpostpolicy branch 2 times, most recently from f770da7 to 54e0d3f Compare November 25, 2024 02:14

additional test for negative case, test coverage for policy, remove c…

946372d

…omment

marktheunissen force-pushed the checksumpostpolicy branch from 54e0d3f to 946372d Compare November 25, 2024 02:19

klauspost approved these changes Nov 25, 2024

View reviewed changes

harshavardhana merged commit 7fad06c into minio:master Nov 25, 2024

marktheunissen deleted the checksumpostpolicy branch November 25, 2024 22:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adjust testPresignedPostPolicy to ensure that GetObject...#1996

Adjust testPresignedPostPolicy to ensure that GetObject...#1996
harshavardhana merged 2 commits intominio:masterfrom
marktheunissen:checksumpostpolicy

marktheunissen commented Sep 2, 2024 •

edited

Loading

Uh oh!

marktheunissen Sep 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

marktheunissen commented Sep 24, 2024

Uh oh!

marktheunissen commented Nov 20, 2024

Uh oh!

Uh oh!

Uh oh!

marktheunissen Nov 21, 2024

Uh oh!

marktheunissen Nov 21, 2024

Uh oh!

marktheunissen Nov 21, 2024

Uh oh!

marktheunissen commented Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		policy := minio.NewPostPolicy()

		if err := policy.SetBucket(""); err == nil {

Conversation

marktheunissen commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marktheunissen Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marktheunissen commented Sep 24, 2024

Uh oh!

marktheunissen commented Nov 20, 2024

Uh oh!

Uh oh!

Uh oh!

marktheunissen Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

marktheunissen Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

marktheunissen Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

marktheunissen commented Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marktheunissen commented Sep 2, 2024 •

edited

Loading

marktheunissen Sep 2, 2024 •

edited

Loading