Skip to content

Fix test_protected_namespace_defaults with -Wdefault #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2024
Merged

Fix test_protected_namespace_defaults with -Wdefault #462

merged 1 commit into from
Nov 3, 2024

Conversation

CyberTailor
Copy link
Contributor

@CyberTailor CyberTailor commented Nov 3, 2024 •
edited
Loading

This test failed with pytest -Wdefault, which distros usually enable for downstream testing to avoid surprise failures.

For example:

$ pytest tests/test_settings.py::test_protected_namespace_defaults -Wdefault

Use proper pytest.warns() method instead of incorrect pytest.raises().

@CyberTailor
Fix test_protected_namespace_defaults with -Wdefault
4bb6087 
This test failed with "pytest -Wdefault", which distros usually enable
for downstream testing to avoid surprise failures.

Use proper `pytest.warns()` method instead of incorrect
`pytest.raises()`.

See: https://mgorny.pl/articles/downstream-testing-python-packages.html#assuming-werror-catching-warnings-as-exceptions
@hramezani hramezani merged commit b2c979c into pydantic:main Nov 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberTailor @hramezani