Fix bug where specifying --format
disables parallelization
#14339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--format
or-f
CLI option is specified,@options.keys
becomes[:format, :formatters]
rather than just[:format]
.To ensure the following code works correctly, I believe we need to add
:formatters
toDEFAULT_PARALLEL_OPTIONS
as well.rubocop/lib/rubocop/cli.rb
Lines 148 to 153 in da5d9d4
Before the change, parallel execution was not enabled by default, as shown below:
After the change, parallel execution is enabled by default.
FYI: As a background, I often run
bundle exec rubocop --format progress --format github
in GitHub Actions, but I noticed that it consistently takes twice as long as expected on the default 2-core machine. That led me to this issue. For now, I’ve worked around this by explicitly adding--parallel
option.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.