Skip to content

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Nov 15, 2024

Changes

Closes #12421
Closes PLT-2643

The PR just adds a check if script exists, because external libs could mess up with DOM and stuff.

Testing

I tested it locally

Docs

N/A

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 9b04a72

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #12444 will not alter performance

Comparing fix/server-island-script (9b04a72) with main (8e135b6)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico merged commit 28dd3ce into main Nov 20, 2024
15 checks passed
@ematipico ematipico deleted the fix/server-island-script branch November 20, 2024 15:08
This was referenced Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server island not work when using preload library

3 participants