utils: rm redundant dep and cleanup #1634
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant dependencies and performs cleanup tasks across the codebase. The changes focus on modernizing code by removing deprecated imports and utilizing newer standard library features.
Key changes:
- Replaces deprecated
golang.org/x/net/contextwith standard librarycontextpackage - Removes unused
golang.org/x/expdependency and replacesmaps.Clearwith built-inclearfunction - Removes unused code including buffer pools, sideband functions, and error constants
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/ioutil/context_test.go | Updates context import and improves string comparison efficiency |
| storage/filesystem/object.go | Removes unused copyBufferPool variable |
| remote.go | Removes unused sideband import and buildSidebandIfSupported function |
| plumbing/format/packfile/parser_cache.go | Replaces golang.org/x/exp/maps with built-in clear function |
| plumbing/format/packfile/packfile.go | Removes unused error constants and os import |
| go.mod | Removes golang.org/x/exp dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@pjbgf hello! |
|
See golang/go#49506 for the deprecation of golang.org/x/net/context. |
sashamelentyev
changed the title
|
@sashamelentyev thanks for looking into this. Please reword the commit replacing This also needs to be rebased, as some of the errors were fixed by #1643. |
No description provided.