Skip to content

feat(translate): generate v3 #9020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 4, 2019
Merged

feat(translate): generate v3 #9020

merged 5 commits into from
Oct 4, 2019

Conversation

busunkim96
Copy link
Contributor

No description provided.

@busunkim96 busunkim96 added the api: translation Issues related to the Cloud Translation API API. label Aug 12, 2019
@busunkim96 busunkim96 requested a review from nnegrey August 12, 2019 21:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2019
tseaver
tseaver reviewed Aug 13, 2019
View reviewed changes
nnegrey
nnegrey approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 13, 2019
@busunkim96
Copy link
Contributor Author

V3 is still under whitelist, so we have been asked to hold off on publishing this.

@busunkim96 busunkim96 changed the title Translate: Generate v3. feat(tarnslate): generate v3 Oct 4, 2019
@busunkim96 busunkim96 changed the title feat(tarnslate): generate v3 feat(translate): generate v3 Oct 4, 2019
@busunkim96 busunkim96 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 4, 2019
@busunkim96
Copy link
Contributor Author

This is good to merge and release now.

@busunkim96 busunkim96 merged commit 12a7f30 into googleapis:master Oct 4, 2019
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
feat(translate): generate v3 (#9020)
ef5bc01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@nnegrey nnegrey nnegrey approved these changes

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: translation Issues related to the Cloud Translation API API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @tseaver @nnegrey @googlebot