core: server stream should not deliver halfClose() when call is immediately cancelled#9362
Merged
YifeiZhuang merged 2 commits intogrpc:masterfrom Jul 12, 2022
Conversation
…r-partial-message-no-halfclose
ejona86
approved these changes
Jul 12, 2022
YifeiZhuang
added
the
TODO:backport
Member
Author
|
@ejona86 do we want to back port the change to v1.48? |
Member
|
Yeah, we want this in v1.48 |
YifeiZhuang
added a commit
to YifeiZhuang/grpc-java
that referenced
this pull request
Jul 28, 2022
…iately cancelled(grpc#9362) Fix a bug where the server stream delivers halfClose() to the call during cancellation. It happens when call has a short deadline. Server sees `INTERNAL, desc: Half-closed without a request` due to the bug.
YifeiZhuang
added a commit
that referenced
this pull request
Jul 29, 2022
…iately cancelled(#9362) Fix a bug where the server stream delivers halfClose() to the call during cancellation. It happens when call has a short deadline. Server sees `INTERNAL, desc: Half-closed without a request` due to the bug.
YifeiZhuang
removed
the
TODO:backport
|
Thanks for this patch @YifeiZhuang! I have confirmed it fixes the issue on our side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client sends headers, message and halfClose.
Before server can complete the call, RST_STREAM is sent because of cancellation.
Due to server application
request()(run in serializingExecutor) possibly delay, server stream scheduledhalfClose()(run in serializingExecutor) beforeMessageAvailable(), causingINTERNAL, desc: Half-closed without a requestat server call.fix #8866