Skip to content

Remove GA feature gate ComponentSLIs #133742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

Remove GA feature gate ComponentSLIs #133742

merged 1 commit into from
Sep 2, 2025

Conversation

carlory
Copy link
Member

@carlory carlory commented Aug 28, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

re-do #127787

Which issue(s) this PR is related to:

Special notes for your reviewer:

/assign @hankang @richabanker @Jefftree

Does this PR introduce a user-facing change?

Removed the `ComponentSLIs` feature gate, which had been promoted to stable as part of the Kubernetes 1.32 release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

@carlory: GitHub didn't allow me to assign the following users: hankang.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

re-do #127787

Which issue(s) this PR is related to:

Special notes for your reviewer:

/assign @hankang @richabanker @Jefftree

Does this PR introduce a user-facing change?

Removes the feature gate ComponentSLIs, which has been promoted to stable since 1.32.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 28, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Instrumentation Aug 28, 2025
@carlory carlory force-pushed the cleanup-ComponentSLIs branch from a550d8e to bf9511e Compare August 28, 2025 08:27
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2025
@Jefftree
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 74add05a37d5c1539f4d8f7dc0dcae7ad993c29c

richabanker
richabanker reviewed Aug 28, 2025
View reviewed changes
staging/src/k8s.io/component-base/metrics/features/kube_features.go
{Version: version.MustParse("1.26"), Default: false, PreRelease: featuregate.Alpha},
{Version: version.MustParse("1.27"), Default: true, PreRelease: featuregate.Beta},
// ComponentSLIs officially graduated to GA in v1.29 but the gate was not updated until v1.32.
// To support emulated versions, keep the gate until v1.35.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment here suggests to keep the gate till v1.35 to support emulated versions. Can we remove the gate just yet? @Jefftree

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're in 1.35 now right?

@dims
Copy link
Member

dims commented Sep 2, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, dims, Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 02e403f into kubernetes:master Sep 2, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Instrumentation Sep 2, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 2, 2025
@carlory carlory deleted the cleanup-ComponentSLIs branch September 3, 2025 07:10
@carlory carlory mentioned this pull request Sep 3, 2025
Open
@lmktfy
Copy link

lmktfy commented Sep 20, 2025

Changelog nit (you can update it retrospectively, even)

-Removes the feature gate ComponentSLIs, which has been promoted to stable since 1.32.
+Removed the `ComponentSLIs` feature gate, which had been promoted to stable as part of the Kubernetes 1.32 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

2 more reviewers

@Jefftree Jefftree Jefftree left review comments

@richabanker richabanker richabanker left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@dims dims

@Jefftree Jefftree

@richabanker richabanker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Instrumentation
Status: Done
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
6 participants
@carlory @k8s-ci-robot @Jefftree @dims @lmktfy @richabanker