Skip to content

Update volume/nfs base image from centos:7 to centos:stream9 #133799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2025
Merged

Update volume/nfs base image from centos:7 to centos:stream9 #133799

merged 2 commits into from
Sep 3, 2025

Conversation

oyiz-michael
Copy link
Contributor

@oyiz-michael oyiz-michael commented Aug 31, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the volume/nfs test image base from centos:7 to quay.io/centos/centos:stream9.

Which issue(s) this PR fixes:

Fixes #131874

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

Additional documentation:
N/A - this is an infrastructure update to test images only.

@oyiz-michael
Update volume/nfs base image from centos:7 to centos:8
73127eb 
- Update BASEIMAGE from centos:7 to centos:8 for all architectures
- Bump VERSION from 1.4 to 1.5
- Addresses issue kubernetes#131874 for updating outdated base images

CentOS 7 is EOL and centos:8 provides better security updates
and modern package versions for the NFS test image.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 31, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @oyiz-michael!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @oyiz-michael. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 31, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 31, 2025
@pacoxu
Copy link
Member

pacoxu commented Sep 1, 2025

https://endoflife.date/centos

IIUC, centos 8 is also end of life.

@mkumatag
Copy link
Member

mkumatag commented Sep 1, 2025

https://endoflife.date/centos

IIUC, centos 8 is also end of life.

+1, lets start using centos stream 9 - https://quay.io/repository/centos/centos?tab=tags

@oyiz-michael
Update to CentOS Stream 9 based on reviewer feedback
9b47a09 
- Update BASEIMAGE to quay.io/centos/centos:stream9 for all architectures
- Update Dockerfile to use dnf (CentOS Stream 9 package manager)
- Update package name from /usr/bin/ps to procps-ng

Addresses reviewer feedback that CentOS 8 is also EOL.
CentOS Stream 9 provides ongoing updates and support.
@oyiz-michael
Copy link
Contributor Author

https://endoflife.date/centos
IIUC, centos 8 is also end of life.

+1, lets start using centos stream 9 - https://quay.io/repository/centos/centos?tab=tags

Thanks for the feedback! I've updated the PR to use CentOS Stream 9 as suggested

@oyiz-michael oyiz-michael changed the title Update volume/nfs base image from centos:7 to centos:8 Update volume/nfs base image from centos:7 to centos:stream9 Sep 1, 2025
mkumatag
mkumatag approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f5928004d20d26befafd8ac3f10cb092b8aea2f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, oyiz-michael

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@oyiz-michael
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 2, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 2, 2025
@oyiz-michael
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@oyiz-michael: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oyiz-michael
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@oyiz-michael: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacoxu
Copy link
Member

pacoxu commented Sep 3, 2025

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2025
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 66ac078 into kubernetes:master Sep 3, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

1 more reviewer

@mkumatag mkumatag mkumatag approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.

Update the BASEIMAGEs to the latest version for test/images
5 participants
@oyiz-michael @k8s-ci-robot @pacoxu @mkumatag @k8s-triage-robot