Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

deps: update com_google_protobuf to 3.18.1#1519

Merged
gcf-merge-on-green[bot] merged 9 commits intomainfrom
dependency-update
Oct 15, 2021
Merged

deps: update com_google_protobuf to 3.18.1#1519
gcf-merge-on-green[bot] merged 9 commits intomainfrom
dependency-update

Conversation

@Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Oct 14, 2021 •
edited
Loading

deps: update guava to v31
deps: update grpc to 1.41.0
deps: update auto-value to 1.8.2
deps: update api-common to 2.0.5
deps: update google-http-client to 1.40.1
feat: remove deprecated Generated annotation
fix: Fix com.google.rpc.Code to StatusCode.Code conversion logic

@Neenu1995 Neenu1995 requested review from a team October 14, 2021 17:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2021
@Neenu1995 Neenu1995 changed the title deps: update com_google_protobuf deps: update com_google_protobuf to 3.18.1 Oct 14, 2021
@chanseokoh
Copy link
Contributor

chanseokoh commented Oct 14, 2021

Looks like this causes compilation failure?

@Neenu1995
Copy link
Contributor Author

Neenu1995 commented Oct 14, 2021

Yes.. we are looking into this.

@chanseokoh
Copy link
Contributor

chanseokoh commented Oct 14, 2021

Question: will these annotations come back when these classes are re-generated?

@Generated("by gapic-generator-java")

@Neenu1995
Copy link
Contributor Author

Neenu1995 commented Oct 14, 2021

I don't think code gets automatically re-generated in this repo anymore.

@vam-google
Copy link
Contributor

vam-google commented Oct 14, 2021

@chanseokoh @Neenu1995 The @Generated annotation is not necessary and more of a historical artifact. The clases marked by it were indeed generated by the generator originally, but only to provide the original basic version of classes, which are not expected to be ergenerated in the future but maintained/updated by hand. That is why removing @Generated the right thing to do regardless of the compilation failures.

vam-google
vam-google approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neenu1995 Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 14, 2021
@Neenu1995
Copy link
Contributor Author

Neenu1995 commented Oct 14, 2021

Merge after the release pipeline has been fixed.

@Neenu1995 Neenu1995 changed the title deps: update com_google_protobuf to 3.18.1 feat: update com_google_protobuf to 3.18.1 Oct 15, 2021
@Neenu1995 Neenu1995 changed the title feat: update com_google_protobuf to 3.18.1 deps: update com_google_protobuf to 3.18.1 Oct 15, 2021
@meltsufin meltsufin added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2d76bff into main Oct 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the dependency-update branch October 15, 2021 17:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 15, 2021
@release-please
chore: release 2.6.0 (#1523)
b785ef9 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/gax-java/compare/v2.5.3...v2.6.0) (2021-10-15)


### Features

* remove deprecated Generated annotation ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))


### Bug Fixes

* Fix com.google.rpc.Code to StatusCode.Code conversion logic ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))


### Dependencies

* update api-common to 2.0.5 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update auto-value to 1.8.2 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update com_google_protobuf to 3.18.1 ([#1519](https://www.github.com/googleapis/gax-java/issues/1519)) ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update google-http-client to 1.40.1 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update grpc to 1.41.0 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
* update guava to v31 ([2d76bff](https://www.github.com/googleapis/gax-java/commit/2d76bff6d64da818a3aff7ea0bdf5a36b82c3464))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

@meltsufin meltsufin meltsufin approved these changes

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Neenu1995 @chanseokoh @vam-google @meltsufin