feat: base transaction retries on error codes #129
Merged
BenWhitehead merged 5 commits intogoogleapis:masterfrom Apr 1, 2020
Merged
feat: base transaction retries on error codes #129BenWhitehead merged 5 commits intogoogleapis:masterfrom
BenWhitehead merged 5 commits intogoogleapis:masterfrom
Conversation
Update Fork
googlebot
added
the
cla: yes
schmidt-sebastian
changed the title
schmidt-sebastian
force-pushed
the
mrschmidt/transactionretries
branch
2 times, most recently
from
79a8dd2 to
0aafdb5
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/transactionretries
branch
from
b40a2e8 to
fcd4ea1
Compare
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
============================================
+ Coverage 71.62% 72.58% +0.96%
- Complexity 969 988 +19
============================================
Files 62 63 +1
Lines 5222 5270 +48
Branches 579 590 +11
============================================
+ Hits 3740 3825 +85
+ Misses 1302 1259 -43
- Partials 180 186 +6
Continue to review full report at Codecov.
|
Contributor
Author
|
@BenWhitehead Can you ask someone to review or review this yourself if you have time? This one is a little trickier :/ |
Collaborator
|
@schmidt-sebastian Sure, I'll dig into this tomorrow first thing. |
BenWhitehead
requested changes
Mar 27, 2020
Collaborator
BenWhitehead
left a comment
BenWhitehead
left a comment
There was a problem hiding this comment.
Mostly looks okay. A few questions and one request to move a method.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/LocalFirestoreHelper.java
Show resolved
Hide resolved
Contributor
Author
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
Thank you for the review! All feedback addressed.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/LocalFirestoreHelper.java
Show resolved
Hide resolved
schmidt-sebastian
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
BenWhitehead
approved these changes
Mar 30, 2020
Collaborator
BenWhitehead
left a comment
BenWhitehead
left a comment
There was a problem hiding this comment.
LGTM I'm looking into the Linkage Checker status check failure and will let you know if it requires anything to be change in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of googleapis/nodejs-firestore#953
Implements go/transaction-retry-matrix for Java and cleans up some of the tests: