fix: use test credentials when connecting to the Emulator from Admin SDK#296
Merged
BenWhitehead merged 1 commit intomasterfrom Jul 16, 2020
Merged
fix: use test credentials when connecting to the Emulator from Admin SDK#296BenWhitehead merged 1 commit intomasterfrom
BenWhitehead merged 1 commit intomasterfrom
Conversation
google-cla
bot
added
the
cla: yes
yuchenshi
approved these changes
Jul 15, 2020
yuchenshi
left a comment
yuchenshi
left a comment
There was a problem hiding this comment.
Do we have regression tests though?
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=========================================
Coverage 72.98% 72.98%
Complexity 1044 1044
=========================================
Files 64 64
Lines 5526 5526
Branches 645 645
=========================================
Hits 4033 4033
Misses 1282 1282
Partials 211 211
Continue to review full report at Codecov.
|
Contributor
Author
|
Unfortunately, we don't have any automated regressions tests that involve multiple projects. I verified with the customer's repo that their problem no longer exists and verified that our integration tests still pass against the Emulator even when the Admin SDK is not involved (well, there are two failures, but they existed prior to this change). |
BenWhitehead
approved these changes
Jul 16, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 20, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.35.2](https://www.github.com/googleapis/java-firestore/compare/v1.35.1...v1.35.2) (2020-07-16) ### Bug Fixes * add Internal#autoId() ([#292](https://www.github.com/googleapis/java-firestore/issues/292)) ([b91c57c](https://www.github.com/googleapis/java-firestore/commit/b91c57c4b2d3e92478ceaa1a39d467c40e1344dc)) * add support for deleting nested fields that contain periods ([#295](https://www.github.com/googleapis/java-firestore/issues/295)) ([84f602e](https://www.github.com/googleapis/java-firestore/commit/84f602ef8be67e5748b77e549d46ea53d0c74335)) * use test credentials when connecting to the Emulator from the Firebase Admin SDK ([#296](https://www.github.com/googleapis/java-firestore/issues/296)) ([a0a6e80](https://www.github.com/googleapis/java-firestore/commit/a0a6e806217693fc62a4cf432354c76e719aa140)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#289](https://www.github.com/googleapis/java-firestore/issues/289)) ([2ddb8f1](https://www.github.com/googleapis/java-firestore/commit/2ddb8f133dd3bf31d28bf6bd67cddf8ba2e8846b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes firebase/firebase-admin-java#452