fix: handle thrown exceptions in runAsyncTransaction callback#671
Merged
thebrianchen merged 5 commits intomasterfrom Jun 25, 2021
Merged
fix: handle thrown exceptions in runAsyncTransaction callback#671thebrianchen merged 5 commits intomasterfrom
thebrianchen merged 5 commits intomasterfrom
Conversation
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
Did you look at
? It might be cleaner to follow the same pattern here.
Author
I saw that, but it's only clean for synchronous functions. For async callbacks that return an ApiFuture, I think the only way is to add a callback. |
| } | ||
| try { | ||
| ApiFutures.addCallback( | ||
| userCallback.updateCallback(transaction), |
Contributor
There was a problem hiding this comment.
I think this code would be easier to understand if you did something like this:
try {
const result = userCallback.updateCallback(transaction)
ApiFutures.addCallback(...)
} catch (Exception e) {
callbackResult.setException(e);
}
It's very hard to tell what the try/catch block addresses. The other alternative is to wrap the callback in a try/catch before passing it here like in TransactionAsyncAdapter.
Author
There was a problem hiding this comment.
Done, moved it out into a separate variable.
schmidt-sebastian
approved these changes
Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #667.
The callback
onFailureis only triggered if the ApiFuture contains the exception. When a runtime exception is thrown neither theonFailurenoronSuccesshandler is called, leading the ApiFuture to hang and never complete.The fix adds a
catchingAsync()aroundupdateCallbackto guard against thrown exceptions. Added a system test for redundancy, but I can remove it. Both tests fail (never complete) when run against master.