Skip to content

fix: Important the correct constants and use v1 for tensorboard experiments #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkovalski merged 4 commits into from
Dec 14, 2021
Merged

fix: Important the correct constants and use v1 for tensorboard experiments #905

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c392d7b
fix: Important the correct constants and use v1 for tensorboard exper…
mkovalski Dec 13, 2021
e5b152c
Merge branch 'main' into v1_profiler
mkovalski Dec 13, 2021
814ea2d
fix: fixing linting errors
mkovalski Dec 14, 2021
4c81fb1
Merge branch 'v1_profiler' of github.com:mkovalski/python-aiplatform …
mkovalski Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions google/cloud/aiplatform/training_utils/cloud_profiler/plugins/tensorflow/tensorboard_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,10 @@
from google.api_core import exceptions
from google.cloud import aiplatform
from google.cloud import storage
from google.cloud.aiplatform.constants import base as constants
from google.cloud.aiplatform.utils import TensorboardClientWithOverride
from google.cloud.aiplatform.tensorboard import uploader_utils
from google.cloud.aiplatform.compat.types import (
tensorboard_experiment_v1beta1 as tensorboard_experiment,
)
from google.cloud.aiplatform.compat.types import tensorboard_experiment
from google.cloud.aiplatform.tensorboard.plugins.tf_profiler import profile_uploader
from google.cloud.aiplatform import training_utils

Expand All @@ -42,9 +41,8 @@

def _get_api_client() -> TensorboardClientWithOverride:
"""Creates an Tensorboard API client."""
aiplatform.constants.API_BASE_PATH = (
training_utils.environment_variables.tensorboard_api_uri
)
constants.API_BASE_PATH = training_utils.environment_variables.tensorboard_api_uri

m = re.match(
"projects/.*/locations/(.*)/tensorboards/.*",
training_utils.environment_variables.tensorboard_resource_name,
Expand Down