feat: support for async bidi streaming apis #836
Conversation
python versions <= 3.10 dont support `async with asyncio.timeout`
provide support for the same.
…into feat/834-bidi-async-support
these files will be removed once googleapis/python-api-core#836 gets submitted
* Add async bidiRpc files in python-storage these files will be removed once googleapis/python-api-core#836 gets submitted * fix import path for bidi_base
google/api_core/bidi_async.py
Outdated
| otherwise open-ended set of requests to send through a request-streaming | ||
| (or bidirectional) RPC. | ||
| The reason this is necessary is because it lets the user have control on |
There was a problem hiding this comment.
Consider keeping (and clarifying?) the "The reason this is necessary..." paragraph from _RequestQueueGenerator, especially since the next pargraph below also talks about technical details. Or we could put both technical details in comments rather than in the docstring.
WDYT?
There was a problem hiding this comment.
sure, I've moved this paragraph and next two to class level comments, PTAL and resolve the comments if it looks good.
|
|
||
| request_generator.call = call | ||
|
|
||
| if hasattr(call, "_wrapped"): # pragma: NO COVER |
There was a problem hiding this comment.
Was the TODO in the original file addressed?
There was a problem hiding this comment.
not sure, is there any issue number ? or internal bugId ?
|
Adding @daniel-sanche for visibility. @ohmayr , do you have any remaining concerns with the code? |
…into feat/834-bidi-async-support
@vchudnov-g Addressed your comments. PTAL |
feat: support for async bidi streaming apis
Further details can be found here
Fixes #834