docs(samples): add more clustering code snippets#330
Merged
gcf-merge-on-green[bot] merged 7 commits intogoogleapis:masterfrom Nov 17, 2020
Merged
docs(samples): add more clustering code snippets#330gcf-merge-on-green[bot] merged 7 commits intogoogleapis:masterfrom
gcf-merge-on-green[bot] merged 7 commits intogoogleapis:masterfrom
Conversation
google-cla
bot
added
the
cla: yes
ryanyuan
force-pushed
the
add-sample-code-clustering
branch
from
e15442f to
2ca69be
Compare
product-auto-label
bot
added
api: bigquery
tswast
requested changes
Oct 29, 2020
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Thanks for the contribution! A couple of nits
|
|
||
| def client_query_destination_table_clustered(table_id): | ||
|
|
||
| # [START bigquery_query_destination_table_clustered] |
Contributor
There was a problem hiding this comment.
We need to standardize with what the other languages are using.
Suggested change
| # [START bigquery_query_destination_table_clustered] | |
| # [START bigquery_query_clustered_table] |
| table = client.get_table(table_id) # Make an API request. | ||
| if table.clustering_fields == cluster_fields: | ||
| print("The destination table is written using the cluster_fields configuration.") | ||
| # [END bigquery_query_destination_table_clustered] |
Contributor
There was a problem hiding this comment.
Suggested change
| # [END bigquery_query_destination_table_clustered] | |
| # [END bigquery_query_clustered_table] |
samples/load_table_clustered.py
Outdated
| source_format=bigquery.SourceFormat.CSV, | ||
| ) | ||
|
|
||
| with open(file_path, "rb") as source_file: |
Contributor
There was a problem hiding this comment.
Nit: The Go sample loads from GCS "gs://cloud-samples-data/bigquery/sample-transactions/transactions.csv"
It'd be nice if we had some consistency across languages. Also, it's a little bit simpler to run the sample without the need for local files.
Go sample:
|
Here is the summary of changes. You added 4 region tags.This comment is generated by snippet-bot. |
tswast
approved these changes
Nov 4, 2020
tswast
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
@tswast thanks for the review and changes. |
tswast
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sample code for creating a clustered table from a query result.
File: samples/client_query_destination_table_clustered.py
Section: https://cloud.google.com/bigquery/docs/creating-clustered-tables#creating_a_clustered_table_from_a_query_result
Add sample code for creating a clustered table when you load data.
File: samples/load_table_clustered.py
Section: https://cloud.google.com/bigquery/docs/creating-clustered-tables#creating_a_clustered_table_when_you_load_data
Fixes #329 🦕