This repository was archived by the owner on Sep 5, 2023. It is now read-only.
feat: add v1p1beta1; add resource_display_name, resource_parent_display_name, resource_project_display_name to v1.Asset.SecurityCenterProperties; add output only field resource to v1.ListFindingsResponse.ListFindingsResult; increase initial_rpc_timeout_millis` in default config for v1; standardize use of 'required' and 'optional' in docstrings; add 2.7 deprecation warning; bump copyright year to 2020#7
Merged
busunkim96 merged 9 commits intomasterfrom Feb 13, 2020
Merged
feat: add v1p1beta1; add resource_display_name, resource_parent_display_name, resource_project_display_name to v1.Asset.SecurityCenterProperties; add output only field resource to v1.ListFindingsResponse.ListFindingsResult; increase initial_rpc_timeout_millis` in default config for v1; standardize use of 'required' and 'optional' in docstrings; add 2.7 deprecation warning; bump copyright year to 2020#7busunkim96 merged 9 commits intomasterfrom
resource_display_name, resource_parent_display_name, resource_project_display_name to v1.Asset.SecurityCenterProperties; add output only field resource to v1.ListFindingsResponse.ListFindingsResult; increase initial_rpc_timeout_millis` in default config for v1; standardize use of 'required' and 'optional' in docstrings; add 2.7 deprecation warning; bump copyright year to 2020#7busunkim96 merged 9 commits intomasterfrom
Conversation
resource_display_name, resource_parent_display_name, resource_project_display_name to v1.Asset.SecurityCenterProperties; add output only field resource to v1.ListFindingsResponse.ListFindingsResult; increase initial_rpc_timeout_millis` in default config for v1; standardize use of 'required' and 'optional' in docstrings; add 2.7 deprecation warning; bump copyright year to 2020
cf1a830 to
2f581b8
Compare
crwilcox
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: