Skip to content

feat(testing): add final cypress e2e tests and all required fixes #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

feat(testing): add final cypress e2e tests and all required fixes #970

wants to merge 5 commits into from
+73 −25

Conversation

seershan
Copy link

@seershan seershan commented Sep 8, 2025

Thank you for submitting a pull request to the WrongSecrets Party!

What kind of changes does this PR include?

  • A new feature
  • Fixes or refactors

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added tests to ensure my change works (if applicable)
  • The PR passes pre-commit hooks and automated tests

This pull request adds a comprehensive suite of Cypress End-to-End tests and a new GitHub Action workflow to run them automatically, fulfilling the requirements of issue #284.

The tests cover the following user workflows:

  • Creating and joining a team with a passcode.
  • Logging into the admin interface.

This PR also includes necessary fixes to the deployment scripts and Helm configuration to ensure the local and CI/CD environments run correctly on different platforms.

Closes #284

@seershan
Copy link
Author

seershan commented Sep 8, 2025

@commjoen I hope it passes all the tests now :)

@commjoen
Copy link
Collaborator

we still have an issue:

error: unable to forward port because pod is not running. Current status=Pending
Error from server (NotFound): services "prometheus-server" not found
Error from server (NotFound): services "grafana" not found

alternatively you can try to maek it all part of one shell script where you do the ready-check and then start cypress maybe? would that make it simpler?

@seershan seershan mentioned this pull request Sep 10, 2025
Open
6 tasks
@seershan
Copy link
Author

we still have an issue:

error: unable to forward port because pod is not running. Current status=Pending
Error from server (NotFound): services "prometheus-server" not found
Error from server (NotFound): services "grafana" not found

alternatively you can try to maek it all part of one shell script where you do the ready-check and then start cypress maybe? would that make it simpler?

Hi @commjoen,

Thank you for your patience and guidance. I've pushed a final, clean update to this pull request that should resolve all the failing checks.

Following your advice, this new version now uses a single, robust shell script (scripts/run-e2e-tests.sh) to manage the entire test process (deploying the app, waiting for it to be ready, and running the Cypress tests) in the CI environment.

This pull request now contains the complete and working Cypress tests, the new test script, and the simplified GitHub Action workflow. All tests are passing on my local machine. This should be ready for a final review. Thanks!

The new one is #972

@seershan seershan closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen Awaiting requested review from commjoen commjoen is a code owner

@bendehaan bendehaan Awaiting requested review from bendehaan bendehaan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create cypres test for full round trip (webtop &wrongsecrets)
2 participants
@seershan @commjoen