feat(ci): implement new single-script e2e test workflow #972
+197
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
commjoen
reviewed
Sep 12, 2025
.github/workflows/e2e-tests.yml
Outdated
| - name: Install yq | ||
| run: sudo wget https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 -O /usr/bin/yq && sudo chmod +x /usr/bin/yq | ||
| - name: Run Deployment Script | ||
| run: ./build-and-deploy-minikube.sh |
There was a problem hiding this comment.
it seems it is still waiting here as the script will never end. Instead it might be better to run this in the background (e.g. ./build-and-deploy-minikube.sh & and then do a poll:
Suggested change
| run: ./build-and-deploy-minikube.sh | |
| run: | | |
| ./build-and-deploy-minikube.sh & | |
| pause 10 | |
| kubectl wait --for=condition=ready pod -l app=wrongsecrets-balancer --timeout=2s |
|
Hi @seershan , it's been a while! Hope you are doing great! |
|
Hello @commjoen actually im out of station currently, I will start again by Tuesday. |
|
all good! Have a good time and will see the commits later 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request to the WrongSecrets Party!
What kind of changes does this PR include?
Checklist:
This pull request adds a suite of Cypress End-to-End tests and a new GitHub Action to run them, fulfilling the requirements of issue #284. It also includes the necessary fixes to the deployment scripts and configuration to get the local and CI environments working.
This is a clean replacement for the previous pull request (#970).
Closes #284