Add a parameter that skips verify packages step #24763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshigetomi
requested review from
daxian-dbw,
TravisEz13,
adityapatwardhan and
anmenaga
as code owners
|
/azp run PowerShell-CI-macos |
|
/azp run PowerShell-CI-linux |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run PowerShell-CI-windows |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
1 similar comment
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run PowerShell-CI-static-analysis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PowerShell-Windows-Packinging-CI |
|
No pipelines are associated with this pull request. |
|
/azp run PSResourceGet ACR |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run PowerShell-Windows-Packaging-CI |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
TravisEz13
approved these changes
Jan 10, 2025
|
📣 Hey @jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
TravisEz13
added
CL-BuildPackaging
TravisEz13
added
BackPort-7.4.x-Approved
and removed
BackPort-7.5.x-Consider
BackPort-7.4.x-Consider
labels
TravisEz13
pushed a commit
that referenced
this pull request
Jan 15, 2025
* added a parameter that skips verify packages step * fix parameter string to boolean value --------- Co-authored-by: Justin Chung <[email protected]>
TravisEz13
added a commit
that referenced
this pull request
Jan 16, 2025
* added a parameter that skips verify packages step * fix parameter string to boolean value --------- Co-authored-by: Justin Chung <[email protected]> Co-authored-by: Justin Chung <[email protected]>
TravisEz13
pushed a commit
that referenced
this pull request
Jan 16, 2025
* added a parameter that skips verify packages step * fix parameter string to boolean value --------- Co-authored-by: Justin Chung <[email protected]>
TravisEz13
added a commit
that referenced
this pull request
Jan 16, 2025
* added a parameter that skips verify packages step * fix parameter string to boolean value --------- Co-authored-by: Justin Chung <[email protected]> Co-authored-by: Justin Chung <[email protected]>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces a new parameter,
SkipVerifyPackages, to the pipeline configuration files to allow skipping the verification of package licenses. The changes are primarily focused on the addition of this parameter and the conditional logic to handle it.Pipeline Configuration Enhancements:
SkipVerifyPackagesparameter to.pipelines/apiscan-gen-notice.ymlto control the skipping of package verification.extendssection in.pipelines/apiscan-gen-notice.ymlto pass theSkipVerifyPackagesparameter to the compliance template.SkipVerifyPackagesparameter in.pipelines/templates/compliance/generateNotice.ymlto be used within the compliance jobs.generateNoticejob based on theSkipVerifyPackagesparameter.generateNoticejob script.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).