Skip to content

Add a parameter that skips verify packages step #24763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add a parameter that skips verify packages step #24763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e113a88
added a parameter that skips verify packages step
Jan 10, 2025
dcb10d2
fix parameter string to boolean value
Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .pipelines/apiscan-gen-notice.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ parameters:
displayName: Debugging - Enable CodeQL and set cadence to 1 hour
type: boolean
default: false
- name: SkipVerifyPackages
type: boolean
default: false

variables:
- name: ob_outputDirectory
Expand Down Expand Up @@ -103,3 +106,4 @@ extends:
- template: /.pipelines/templates/compliance/generateNotice.yml@self
parameters:
parentJobs: []
SkipVerifyPackages: ${{ parameters.SkipVerifyPackages }}
5 changes: 3 additions & 2 deletions .pipelines/templates/compliance/generateNotice.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
parameters:
- name: parentJobs
type: jobList
- name: SkipVerifyPackages
type: boolean

jobs:
- job: generateNotice
Expand Down Expand Up @@ -60,7 +62,7 @@ jobs:
- pwsh: |
$(repoRoot)/tools/clearlyDefined/ClearlyDefined.ps1 -TestAndHarvest
displayName: Verify that packages have license data

condition: eq(${{ parameters.SkipVerifyPackages }}, false)

- task: msospo.ospo-extension.8d7f9abb-6896-461d-9e25-4f74ed65ddb2.notice@0
displayName: 'NOTICE File Generator'
Expand All @@ -71,7 +73,6 @@ jobs:
# this isn't working
# additionaldata: $(Build.SourcesDirectory)\assets\additionalAttributions.txt


- pwsh: |
Get-Content -Raw -Path $(repoRoot)\assets\additionalAttributions.txt | Out-File '$(ob_outputDirectory)\ThirdPartyNotices.txt' -Encoding utf8NoBOM -Force -Append
Get-Content -Raw -Path $(repoRoot)\assets\additionalAttributions.txt
Expand Down
Loading